Skip to content

Update Microsoft.VMwareCloudSimple provider schema to Cloudsimple 44 release #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhendrixMSFT merged 1 commit into from
Oct 28, 2019
Merged

Update Microsoft.VMwareCloudSimple provider schema to Cloudsimple 44 release #7497

jhendrixMSFT merged 1 commit into from
Oct 28, 2019

Conversation

@mpoliako
Copy link
Contributor

@mpoliako mpoliako commented Oct 15, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 15, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 483ebc4, Iteration 13)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-vmwarecloudsimple [Logs]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from erich-wang October 15, 2019 08:53
@AutorestCI AutorestCI mentioned this pull request Oct 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6167

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 15, 2019

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 15, 2019
Closed
@mpoliako mpoliako force-pushed the feature/update_cloudsimple_swagger_rel44 branch from 5bf923e to fe16507 Compare October 15, 2019 09:10
@AutorestCI AutorestCI mentioned this pull request Oct 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7888

@mpoliako mpoliako force-pushed the feature/update_cloudsimple_swagger_rel44 branch 4 times, most recently from f220faf to 350e165 Compare October 15, 2019 11:51
@mpoliako mpoliako force-pushed the feature/update_cloudsimple_swagger_rel44 branch from 350e165 to 3569147 Compare October 15, 2019 12:45
@tenmozes tenmozes added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 15, 2019
@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2019
KrisBash
KrisBash suggested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment on $filter

@mpoliako mpoliako force-pushed the feature/update_cloudsimple_swagger_rel44 branch from 3569147 to 483ebc4 Compare October 18, 2019 05:29
@mpoliako mpoliako requested a review from KrisBash October 18, 2019 05:39
KrisBash
KrisBash approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 18, 2019
@mpoliako mpoliako changed the title [DO NOT MERGE] Update Microsoft.VMwareCloudSimple provider schema to Cloudsimple 44 release Update Microsoft.VMwareCloudSimple provider schema to Cloudsimple 44 release Oct 23, 2019
@mpoliako
Copy link
Contributor Author

mpoliako commented Oct 23, 2019

@erich-wang @KrisBash
hi guys, could you please merge this pull request,
we have rollout this version of API to production
Thank you

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 23, 2019
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 23, 2019
Merged
@tenmozes tenmozes removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 24, 2019
@mpoliako
Copy link
Contributor Author

mpoliako commented Oct 28, 2019

@erich-wang @KrisBash @jhendrixMSFT
Hi could you please merge this request, we already have this version of API in prod

Thank you

@jhendrixMSFT jhendrixMSFT merged commit b703e88 into Azure:master Oct 28, 2019
@mpoliako
Copy link
Contributor Author

mpoliako commented Oct 28, 2019

@jhendrixMSFT Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

+2 more reviewers

@shivam-msft shivam-msft shivam-msft left review comments

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mpoliako @AutorestCI @azuresdkci @KrisBash @jhendrixMSFT @shivam-msft @tenmozes @erich-wang