Skip to content

Comments

[Azure Search] Carve out a swagger spec for exclusive use by Track 1 .NET SDK#7468

Merged
sarangan12 merged 4 commits intoAzure:masterfrom
arv100kri:arv100kri/track1-freeze
Oct 14, 2019
Merged

[Azure Search] Carve out a swagger spec for exclusive use by Track 1 .NET SDK#7468
sarangan12 merged 4 commits intoAzure:masterfrom
arv100kri:arv100kri/track1-freeze

Conversation

@arv100kri
Copy link
Member

@arv100kri arv100kri commented Oct 11, 2019

  1. https://github.com/Azure/azure-sdk-for-net/tree/master/sdk will only point to the track 1 swagger specs
  2. track 1 swagger has changes from [Azure Search] Add missing $select parameter to List APIs #7371 reverted in order to prime for a SDK deployment that’ll do rebranding changes

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2019

In Testing, Please Ignore

[Logs] (Generated from ae9116e, Iteration 7)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 11, 2019

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • search/data-plane/Microsoft.Azure.Search.Data/track1
  • search/data-plane/Microsoft.Azure.Search.Data
  • search/data-plane/Microsoft.Azure.Search.Service

@AutorestCI
Copy link

AutorestCI commented Oct 11, 2019

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service
  • search/data-plane/Microsoft.Azure.Search.Data/track1
  • search/data-plane/Microsoft.Azure.Search.Data
  • search/data-plane/Microsoft.Azure.Search.Service/track1

Copy link
Contributor

@bleroy bleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for you to revert the unnecessary changes before finishing my review, since this is too many files for GitHub to render at all well.

@arv100kri arv100kri force-pushed the arv100kri/track1-freeze branch from 02563e6 to e396d54 Compare October 12, 2019 03:49
@brjohnstmsft
Copy link
Member

@sarangan12 Some background on this PR: We need to continue maintaining our .NET track 1 SDK while our Track 2 Java SDK is in development. We will need to change the 2019-05-06 Swagger for Track 2 in ways that would break codegen for the .NET track 1 SDK. We discussed this change with the Azure Architecture Review Board already.

@arv100kri
Copy link
Member Author

arv100kri commented Oct 14, 2019

NOTE: Model validation failures are known failures, for which we have an exception

@sarangan12 sarangan12 merged commit dc2bf3c into Azure:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants