Adding hostnames support in Application Gateway Listener Properties by sobaner-zz · Pull Request #7453 · Azure/azure-rest-api-specs

sobaner-zz · 2019-10-10T06:05:11Z

…n gateway listener properties

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…n gateway listener properties

AutorestCI · 2019-10-10T06:07:23Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp7qo8d8jo/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp7qo8d8jo/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4405)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .

<--- Last few GCs --->

[23249:0x3c40cc0]   110123 ms: Mark-sweep 1377.7 (1425.9) -> 1377.3 (1426.4) MB, 1206.4 / 0.0 ms  (average mu = 0.104, current mu = 0.003) allocation failure scavenge might not succeed
[23249:0x3c40cc0]   111715 ms: Mark-sweep 1378.5 (1426.4) -> 1378.0 (1427.4) MB, 1587.4 / 0.0 ms  (average mu = 0.049, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x2a2b9bddbe1d]
Security context: 0x31fea5e1e6e9 <JSObject>
    1: ParseNodeInternal(aka ParseNodeInternal) [0xce21e5a5f91] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~86] [pc=0x2a2b9c7c8397](this=0x1f0e5d7026f1 <undefined>,yamlRootNode=0x06efc19028d1 <Object map = 0x20b7f55f16f9>,yamlNode=0x37db64f59801 <Object map = 0x528d6d685e9>,onErro...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x2a2b9bddbe1d

azuresdkci · 2019-10-10T06:43:29Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-10T06:48:54Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network-october-release
  stderr: 'To https://github.com/Azure/azure-sdk-for-go.git
 ! [rejected]            restapi_auto_network-october-release -> restapi_auto_network-october-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

anton-evseev

Could you also add example for this property?

anton-evseev · 2019-10-10T18:58:56Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-09-01/applicationGateway.json

          "type": "string",
          "description": "Host name of HTTP listener."
        },
+        "hostnames": {


please add new properties at the end to avoid breaking changes in SDKs

anton-evseev · 2019-10-15T22:43:14Z

@sobaner ping

…upport

anton-evseev · 2019-10-16T22:53:47Z

@KrisBash please take a look

KrisBash

LGTM

Updating the swagger spec for hostnames support as part of applicatio…

05943b1

…n gateway listener properties

sobaner-zz requested review from MikhailTryakhov and anton-evseev as code owners October 10, 2019 06:05

azuresdkci assigned sergey-shandar Oct 10, 2019

azuresdkci requested a review from sergey-shandar October 10, 2019 06:17

AutorestCI mentioned this pull request Oct 10, 2019

[AutoPR network/resource-manager] Adding hostnames support in Application Gateway Listener Properties Azure/azure-sdk-for-go#5995

Closed

anton-evseev suggested changes Oct 10, 2019

View reviewed changes

sobaner and others added 2 commits October 16, 2019 17:07

Addressing dev comment

a6c4a54

Merge branch 'network-october-release' into appgw-wildcard-listener-s…

85ed632

…upport

anton-evseev approved these changes Oct 16, 2019

View reviewed changes

anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2019

KrisBash approved these changes Oct 17, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2019

sergey-shandar approved these changes Oct 17, 2019

View reviewed changes

sergey-shandar merged commit 93aa714 into Azure:network-october-release Oct 17, 2019

sobaner-zz mentioned this pull request Jan 13, 2020

Sobaner/wildcardlistener Azure/azure-powershell#10878

Merged

8 tasks

surajmb mentioned this pull request Feb 18, 2020

CLI support for Wildcard Listener in Application Gateway Azure/azure-cli#11743

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding hostnames support in Application Gateway Listener Properties#7453

Adding hostnames support in Application Gateway Listener Properties#7453
sergey-shandar merged 3 commits intoAzure:network-october-releasefrom
sobaner-zz:appgw-wildcard-listener-support

sobaner-zz commented Oct 10, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 10, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Oct 10, 2019

Uh oh!

AutorestCI commented Oct 10, 2019 •

edited

Loading

Uh oh!

anton-evseev left a comment

Uh oh!

anton-evseev Oct 10, 2019

Uh oh!

sobaner-zz Oct 16, 2019

Uh oh!

anton-evseev commented Oct 15, 2019

Uh oh!

anton-evseev commented Oct 16, 2019

Uh oh!

KrisBash left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

sobaner-zz commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 10, 2019

Uh oh!

AutorestCI commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

sobaner-zz Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev commented Oct 15, 2019

Uh oh!

anton-evseev commented Oct 16, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sobaner-zz commented Oct 10, 2019 •

edited

Loading

AutorestCI commented Oct 10, 2019 •

edited

Loading

AutorestCI commented Oct 10, 2019 •

edited

Loading