add AKS rotateClusterCertificates API by andyzhangx · Pull Request #7436 · Azure/azure-rest-api-specs

andyzhangx · 2019-10-09T07:51:02Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/hold

openapi-sdkautomation · 2019-10-09T07:51:05Z

In Testing, Please Ignore

[Logs] (Generated from 965878a, Iteration 6)

Python: test-repo-billy/azure-sdk-for-python [Logs]

No packages generated.

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

containerservice/resource-manager/v2019_06_01 [Logs] [Instructions]
containerservice/resource-manager/v2019_08_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

containerservice/mgmt/2017-07-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-07-01.zip
containerservice/mgmt/2017-08-31 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-08-31.zip
containerservice/mgmt/2017-09-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-09-30.zip
containerservice/mgmt/2018-03-31 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2018-03-31.zip
containerservice/mgmt/2019-02-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-02-01.zip
containerservice/mgmt/2019-04-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-04-30.zip
containerservice/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-06-01.zip
containerservice/mgmt/2019-08-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-08-01.zip
preview/containerservice/mgmt/2018-08-01-preview [Logs] [Instructions] [Generation PR]
- preview.containerservice.mgmt.2018-08-01-preview.zip
preview/containerservice/mgmt/2018-09-30-preview [Logs] [Instructions] [Generation PR]
- preview.containerservice.mgmt.2018-09-30-preview.zip
preview/containerservice/mgmt/2019-09-30-preview [Logs] [Instructions] [Generation PR]
- preview.containerservice.mgmt.2019-09-30-preview.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-containerservice [Logs] [Instructions]
- azure-arm-containerservice-10.0.0.tgz

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.ContainerService [Logs] [Instructions]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-10-09T07:52:25Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8062

AutorestCI · 2019-10-09T07:53:53Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6095

azuresdkci · 2019-10-09T08:00:29Z

Can one of the admins verify this patch?

andyzhangx · 2019-10-09T09:17:59Z

hold on this PR until original AKS rotate-certs code merged into AKS code branch.

KrisBash

Signing off with comment. If there are response bodies for the action, please model those in swagger.

...erservice/resource-manager/Microsoft.ContainerService/stable/2019-08-01/managedClusters.json

andyzhangx · 2019-10-11T08:44:49Z

cc @yangl900 @weinong for review

jhendrixMSFT · 2019-10-17T16:57:22Z

@andyzhangx hello any update?

andyzhangx · 2019-10-19T02:47:23Z

@andyzhangx hello any update?

the rotateClusterCertificates API has been merged in AKS, and I have removed 200 response in the PR. Why is this PR failing? @jhendrixMSFT

andyzhangx · 2019-10-21T05:45:35Z

@jhendrixMSFT I have updated this PR, pls take a review, thanks.

add aks rotate-certs operation for 2019-08-01

d5779d2

AutorestCI mentioned this pull request Oct 9, 2019

[AutoPR containerservice/resource-manager] [WIP]add aks rotate-certs operation for 2019-08-01 Azure/azure-sdk-for-python#7717

Closed

azuresdkci assigned jhendrixMSFT Oct 9, 2019

azuresdkci requested a review from jhendrixMSFT October 9, 2019 07:52

AutorestCI mentioned this pull request Oct 9, 2019

[AutoPR containerservice/resource-manager] [WIP]add aks rotate-certs operation for 2019-08-01 Azure/azure-sdk-for-go#5982

Closed

openapi-sdkautomation bot mentioned this pull request Oct 9, 2019

[AutoPR Microsoft.Azure.Management.ContainerService] [WIP]add aks rotate-certs operation for 2019-08-01 test-repo-billy/azure-sdk-for-net#292

Closed

jhendrixMSFT added DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2019

KrisBash approved these changes Oct 9, 2019

View reviewed changes

...erservice/resource-manager/Microsoft.ContainerService/stable/2019-08-01/managedClusters.json Outdated Show resolved Hide resolved

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2019

This was referenced Oct 19, 2019

[AutoPR containerservice/resource-manager] [WIP]add aks rotate-certs operation for 2019-08-01 Azure/azure-sdk-for-python#8061

Closed

[AutoPR containerservice/resource-manager] [WIP]add aks rotate-certs operation for 2019-08-01 Azure/azure-sdk-for-go#6088

Merged

openapi-sdkautomation bot mentioned this pull request Oct 19, 2019

[AutoPR containerservice/resource-manager/v2019_06_01] [WIP]add aks rotate-certs operation for 2019-08-01 test-repo-billy/azure-sdk-for-java#709

Closed

andyzhangx changed the title ~~[WIP]add aks rotate-certs operation for 2019-08-01~~ add aks rotate-certs operation for 2019-08-01 Oct 19, 2019

andyzhangx changed the title ~~add aks rotate-certs operation for 2019-08-01~~ add AKS rotateClusterCertificates API for 2019-08-01 Oct 19, 2019

andyzhangx changed the title ~~add AKS rotateClusterCertificates API for 2019-08-01~~ add AKS rotateClusterCertificates API Oct 19, 2019

feat: use 204 instead of 200

965878a

andyzhangx force-pushed the aks-rotate-certs branch from 018a5fa to 965878a Compare October 20, 2019 11:36

jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 21, 2019

jhendrixMSFT approved these changes Oct 21, 2019

View reviewed changes

jhendrixMSFT merged commit 6004a8b into Azure:master Oct 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add AKS rotateClusterCertificates API#7436

add AKS rotateClusterCertificates API#7436
jhendrixMSFT merged 2 commits intoAzure:masterfrom
andyzhangx:aks-rotate-certs

andyzhangx commented Oct 9, 2019

Uh oh!

openapi-sdkautomation bot commented Oct 9, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 9, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 9, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Oct 9, 2019

Uh oh!

andyzhangx commented Oct 9, 2019

Uh oh!

KrisBash left a comment

Uh oh!

Uh oh!

andyzhangx commented Oct 11, 2019

Uh oh!

jhendrixMSFT commented Oct 17, 2019

Uh oh!

andyzhangx commented Oct 19, 2019

Uh oh!

andyzhangx commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

andyzhangx commented Oct 9, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 965878a, Iteration 6)

Uh oh!

AutorestCI commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 9, 2019

Uh oh!

andyzhangx commented Oct 9, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andyzhangx commented Oct 11, 2019

Uh oh!

jhendrixMSFT commented Oct 17, 2019

Uh oh!

andyzhangx commented Oct 19, 2019

Uh oh!

andyzhangx commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

openapi-sdkautomation bot commented Oct 9, 2019 •

edited

Loading

AutorestCI commented Oct 9, 2019 •

edited

Loading

AutorestCI commented Oct 9, 2019 •

edited

Loading