Skip to content

added private FQDN#7430

Merged
jhendrixMSFT merged 3 commits intoAzure:dev-containerservice-Microsoft.ContainerService-2019-10-01from
weinong:v20191001-aks-private-cluster
Oct 17, 2019
Merged

added private FQDN#7430
jhendrixMSFT merged 3 commits intoAzure:dev-containerservice-Microsoft.ContainerService-2019-10-01from
weinong:v20191001-aks-private-cluster

Conversation

@weinong
Copy link
Copy Markdown
Contributor

@weinong weinong commented Oct 8, 2019 •
edited by xizha162
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@xizha162 xizha162 self-requested a review October 8, 2019 22:47
@xizha162
Copy link
Copy Markdown
Contributor

xizha162 commented Oct 8, 2019

LGTM

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Oct 8, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 10, 2019

@sergey-shandar can you review this PR? I think I need one more?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 10, 2019
@sergey-shandar sergey-shandar self-assigned this Oct 10, 2019
@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 15, 2019

@KrisBash are you the right person to review from ARM side?

@sauryadas
Copy link
Copy Markdown

sauryadas commented Oct 16, 2019

@ravbhatnagar Please help with this review. This is work scheduled for Ignite.

KrisBash
KrisBash approved these changes Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019
@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 16, 2019

@sergey-shandar can you help merge it?

@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Oct 17, 2019

@weinong could you fix Avocado issues https://dev.azure.com/azure-sdk/public/_build/results?buildId=135289&view=logs&jobId=f10f5372-40ed-54fc-caa4-b1cb5bd1252b ?

@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 17, 2019

@sergey-shandar I removed the example as it will be a duplicate key in swagger. After all, it's the same API as ManagedClusters_Get. Just a variant feature.

@weinong
Copy link
Copy Markdown
Contributor Author

weinong commented Oct 17, 2019

@jhendrixMSFT would you be able to help merge it while Sergey is OOF please?

@jhendrixMSFT jhendrixMSFT merged commit 75e24df into Azure:dev-containerservice-Microsoft.ContainerService-2019-10-01 Oct 17, 2019
xizha162 pushed a commit to xizha162/azure-rest-api-specs that referenced this pull request Oct 21, 2019
@weinong
added private FQDN (Azure#7430)
2033108 
* added private FQDN

* added example

* remove example
@xizha162 xizha162 mentioned this pull request Oct 21, 2019
Merged
5 tasks
ArcturusZhang pushed a commit that referenced this pull request Oct 22, 2019
@ArcturusZhang
Publish container service 2019-10-01 api version (#7567)
cf9e1b3 
* Adds base for updating Microsoft.ContainerService from version stable/2019-08-01 to version 2019-10-01

* Updates readme

* Updates API version in new specs and examples

* added private FQDN (#7430)

* added private FQDN

* added example

* remove example

* updating sdk tags for 2019-10-01 api version (#7550)

* updating sdk tags for 2019-10-01 api version

* fixing ci errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xizha162 xizha162 Awaiting requested review from xizha162

2 more reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@weinong @AutorestCI @xizha162 @azuresdkci @sauryadas @sergey-shandar @KrisBash @jhendrixMSFT