Skip to content

[Hub Generated] Review request for Microsoft.ManagedServices to add version stable/2019-09-01#7426

Merged
zikalino merged 4 commits intoAzure:masterfrom
ajay-sainy:dev-managedservices-Microsoft.ManagedServices-2019-09-01
Oct 23, 2019
Merged

[Hub Generated] Review request for Microsoft.ManagedServices to add version stable/2019-09-01#7426
zikalino merged 4 commits intoAzure:masterfrom
ajay-sainy:dev-managedservices-Microsoft.ManagedServices-2019-09-01

Conversation

@ajay-sainy
Copy link
Copy Markdown
Member

@ajay-sainy ajay-sainy commented Oct 8, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Oct 8, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 458d272, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning managedservices/mgmt/2019-06-01 [Logs]
  • Warning preview/managedservices/mgmt/2018-06-01 [Logs]
  • Warning preview/managedservices/mgmt/2019-04-01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from zikalino October 8, 2019 16:24
@AutorestCI AutorestCI mentioned this pull request Oct 8, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8060

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@ajay-sainy ajay-sainy mentioned this pull request Oct 8, 2019
Closed
5 tasks
@openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Oct 8, 2019
Merged
@KrisBash KrisBash added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 8, 2019
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Oct 8, 2019

Can one of the admins verify this patch?

@sanjaiganesh sanjaiganesh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019
@ajay-sainy ajay-sainy force-pushed the dev-managedservices-Microsoft.ManagedServices-2019-09-01 branch from cab6b95 to 7afb2b3 Compare October 19, 2019 01:59
@AutorestCI AutorestCI mentioned this pull request Oct 19, 2019
Closed
@ajay-sainy ajay-sainy force-pushed the dev-managedservices-Microsoft.ManagedServices-2019-09-01 branch from 7afb2b3 to b986651 Compare October 22, 2019 00:51
@ajay-sainy
Using the filter for collection call to return specific definitions.
458d272 
Created separate path for point get call.

Previous comment: New api-version, having new resource type - marketplaceregistrationdefinition.
@ajay-sainy ajay-sainy force-pushed the dev-managedservices-Microsoft.ManagedServices-2019-09-01 branch from b986651 to 458d272 Compare October 22, 2019 00:54
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Oct 22, 2019
anthony-c-martin
anthony-c-martin approved these changes Oct 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajay-sainy
Copy link
Copy Markdown
Member Author

ajay-sainy commented Oct 23, 2019

@zikalino Could you please review the PR?

@openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Oct 23, 2019
Merged
@zikalino zikalino merged commit 455fbe8 into Azure:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-c-martin anthony-c-martin Awaiting requested review from anthony-c-martin

2 more reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zikalino zikalino

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ajay-sainy @AutorestCI @azuresdkci @sanjaiganesh @zikalino @anthony-c-martin @KrisBash