Swagger perSite and perListener firewall policy - 2019_09_01 by venk8 · Pull Request #7401 · Azure/azure-rest-api-specs

venk8 · 2019-10-04T04:31:09Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-10-04T04:33:13Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp00s9442e/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp00s9442e/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .

<--- Last few GCs --->

[11485:0x3a4ecc0]   118542 ms: Mark-sweep 1377.3 (1425.6) -> 1377.2 (1425.6) MB, 1421.8 / 0.0 ms  (average mu = 0.129, current mu = 0.001) allocation failure GC in old space requested
[11485:0x3a4ecc0]   119943 ms: Mark-sweep 1377.2 (1425.6) -> 1377.2 (1425.6) MB, 1401.4 / 0.0 ms  (average mu = 0.068, current mu = 0.000) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xa4605ddbe1d]
    1: StubFrame [pc: 0xa4605dda1bb]
Security context: 0x1cc99bb1e6e9 <JSObject>
    2: set [0x1cc99bb137b9](this=0x38f2e0593481 <JSWeakMap>,0x127a30422f59 <Object map = 0x1561bf1459b9>,0x2e01a4ab6a29 <String[5]: 15769>)
    3: /* anonymous */(aka /* anonymous */) [0x29417e5ad9c9] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed5bfa v8::internal::Heap::CollectAllAvailableGarbage(v8::internal::GarbageCollectionReason) [node]
10: 0xed73de v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
11: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
12: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
13: 0xea0d90 v8::internal::Handle<v8::internal::FixedArray> v8::internal::Factory::NewFixedArrayWithMap<v8::internal::FixedArray>(v8::internal::Heap::RootListIndex, int, v8::internal::PretenureFlag) [node]
14: 0xfdc4c1 v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
15: 0xfdc51e v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
16: 0xfecd7f v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
17: 0xfff128 v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
18: 0xfff346 v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
19: 0x1115310 v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
20: 0xa4605ddbe1d

azuresdkci · 2019-10-04T05:11:39Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-04T05:33:25Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5953

anton-evseev

Please also rebase your branch to remove unrelated commits (52 is too much)

...ion/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json

anton-evseev · 2019-10-04T19:34:38Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json

+          "readOnly": true,
+          "type": "array",
+          "items": {
+            "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayHttpListener"


If this is a list of references it should be of type ./network.json#/definitions/SubResource

addressed the comment.

anton-evseev · 2019-10-04T20:18:23Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json

+          "readOnly": true,
+          "type": "array",
+          "items": {
+            "$ref": "./applicationGateway.json#/definitions/SubResource"


Suggested change

"$ref": "./applicationGateway.json#/definitions/SubResource"

"$ref": "./network.json#/definitions/SubResource"

anton-evseev · 2019-10-04T20:18:31Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json

+          "readOnly": true,
+          "type": "array",
+          "items": {
+            "$ref": "./applicationGateway.json#/definitions/SubResource"


Suggested change

"$ref": "./applicationGateway.json#/definitions/SubResource"

"$ref": "./network.json#/definitions/SubResource"

Update specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json fixing review comments Co-Authored-By: Anton Evseev <anton.evseev@protonmail.com> Update specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/webapplicationfirewall.json fixing review comments Co-Authored-By: Anton Evseev <anton.evseev@protonmail.com> support for per listener/per-site firewall policy fixing the deleted extra space

…e/2019-09-01/webapplicationfirewall.json fixing review comments Co-Authored-By: Anton Evseev <anton.evseev@protonmail.com>

KrisBash

LGTM

anton-evseev · 2019-10-08T19:28:45Z

/azp run

azure-pipelines · 2019-10-08T19:29:04Z

Azure Pipelines successfully started running 2 pipeline(s).

anton-evseev · 2019-10-09T20:47:13Z

@tjprescott could you please review and merge?

venk8 requested review from MikhailTryakhov and anton-evseev as code owners October 4, 2019 04:31

venk8 changed the title ~~Swagger perSite and perListener firewall policy - 2019_09_01~~ Swagger perSite and perListener firewall policy - 2019_09_01 [DoNotMerge] Oct 4, 2019

venk8 changed the title ~~Swagger perSite and perListener firewall policy - 2019_09_01 [DoNotMerge]~~ Swagger perSite and perListener firewall policy - 2019_09_01 [DO NOT MERGE] Oct 4, 2019

azuresdkci assigned tjprescott Oct 4, 2019

azuresdkci requested a review from tjprescott October 4, 2019 05:04

AutorestCI mentioned this pull request Oct 4, 2019

[AutoPR network/resource-manager] Swagger perSite and perListener firewall policy - 2019_09_01 [DO NOT MERGE] Azure/azure-sdk-for-go#5953

Closed

anton-evseev suggested changes Oct 4, 2019

View reviewed changes

venk8 and others added 9 commits October 4, 2019 13:50

Top-level WAF

8f03757

enforcing ordering

be5da8e

support for per listener/per-site firewall policy

b0cbda8

Update specification/network/resource-manager/Microsoft.Network/stabl…

68eaac9

…e/2019-09-01/webapplicationfirewall.json fixing review comments Co-Authored-By: Anton Evseev <anton.evseev@protonmail.com>

Update specification/network/resource-manager/Microsoft.Network/stabl…

9cc1372

…e/2019-09-01/webapplicationfirewall.json fixing review comments Co-Authored-By: Anton Evseev <anton.evseev@protonmail.com>

Changing the reference to subresource

d5c0780

enforcing ordering

434706b

changing network.json

83f19b7

venk8 force-pushed the network-october-release branch from 48d6cdf to 83f19b7 Compare October 4, 2019 20:51

remvoing the changes that were not required

2bb9771

tjprescott added DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 7, 2019

KrisBash approved these changes Oct 8, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 8, 2019

anton-evseev approved these changes Oct 8, 2019

View reviewed changes

venk8 changed the title ~~Swagger perSite and perListener firewall policy - 2019_09_01 [DO NOT MERGE]~~ Swagger perSite and perListener firewall policy - 2019_09_01 Oct 9, 2019

anton-evseev removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 9, 2019

tjprescott approved these changes Oct 10, 2019

View reviewed changes

tjprescott merged commit 9eda83e into Azure:network-october-release Oct 10, 2019

	"$ref": "./applicationGateway.json#/definitions/SubResource"
	"$ref": "./network.json#/definitions/SubResource"

Conversation

venk8 commented Oct 4, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 4, 2019

Uh oh!

AutorestCI commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anton-evseev Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

venk8 Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev commented Oct 8, 2019

Uh oh!

azure-pipelines bot commented Oct 8, 2019

Uh oh!

anton-evseev commented Oct 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AutorestCI commented Oct 4, 2019 •

edited

Loading

AutorestCI commented Oct 4, 2019 •

edited

Loading