Skip to content

Comments

chore: jsonfmt peering#7399

Merged
lirenhe merged 1 commit intoAzure:masterfrom
nschonni:chore--jsonfmt-peering
Oct 8, 2019
Merged

chore: jsonfmt peering#7399
lirenhe merged 1 commit intoAzure:masterfrom
nschonni:chore--jsonfmt-peering

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 4, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 4, 2019

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@lirenhe
Copy link
Member

lirenhe commented Oct 7, 2019

@nschonni, I only see the layout modification in the PR, so what is the purpose of this change?

@nschonni
Copy link
Contributor Author

nschonni commented Oct 7, 2019

The purpose is to make the spec conform to the other spec's layout. There currently isn't a CI job that properly flags these issues.

@lirenhe lirenhe merged commit 25926f8 into Azure:master Oct 8, 2019
@nschonni nschonni deleted the chore--jsonfmt-peering branch October 8, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants