Add swagger specs for VirtualHubRouteTableV2#7394
Add swagger specs for VirtualHubRouteTableV2#7394sergey-shandar merged 10 commits intoAzure:network-october-releasefrom
Conversation
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpua55jck0/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpua55jck0/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .
<--- Last few GCs --->
[884:0x3af8cc0] 105913 ms: Mark-sweep 1381.6 (1425.9) -> 1381.2 (1426.4) MB, 1596.1 / 0.0 ms (average mu = 0.110, current mu = 0.010) allocation failure scavenge might not succeed
[884:0x3af8cc0] 107819 ms: Mark-sweep 1382.1 (1426.4) -> 1381.8 (1427.4) MB, 1902.2 / 0.0 ms (average mu = 0.057, current mu = 0.002) allocation failure scavenge might not succeed
<--- JS stacktrace --->
==== JS stack trace =========================================
0: ExitFrame [pc: 0x3b2a1a45be1d]
Security context: 0x1ddec1a9e6e9 <JSObject>
1: /* anonymous */(aka /* anonymous */) [0x1af76c51e591] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~120] [pc=0x3b2a1a9be073](this=0x09ce59e026f1 <undefined>,cache=0x1284e35a1729 <JSWeakMap>,set=0x1af76c51e699 <JSFunction o (sfi = 0xeaacad50d41)>)
2: /* anonymous */(aka /*...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3b2a1a45be1d |
Automation for azure-sdk-for-goA PR has been created for you: |
anton-evseev
left a comment
There was a problem hiding this comment.
Please also address check failures
specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
Outdated
Show resolved
Hide resolved
specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
Show resolved
Hide resolved
| "subscriptionId": "subid", | ||
| "virtualHubName": "virtualHub1", | ||
| "virtualHubRouteTableV2Parameters": { | ||
| "tags": { |
There was a problem hiding this comment.
Are you sure this resource doesn't support tags? I think all tracked resources do that even if they are not top-level
There was a problem hiding this comment.
Adding the tags to the specs did not work either, so going to remove it from the example.
There was a problem hiding this comment.
Since this is a child resource, the tags for it will be propagated from it's parent resource
...cation/network/resource-manager/Microsoft.Network/stable/2019-09-01/expressRouteGateway.json
Show resolved
Hide resolved
specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
Show resolved
Hide resolved
specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
Show resolved
Hide resolved
specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
Show resolved
Hide resolved
…ure-rest-api-specs into network-october-release
ryansbenson
left a comment
There was a problem hiding this comment.
Approved from ARMs side
|
@sergey-shandar please review and merge |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.