Microsoft.Authorization/policy* entities 2019-09-01#7380
Merged
zikalino merged 4 commits intoAzure:masterfrom Oct 30, 2019
Merged
Microsoft.Authorization/policy* entities 2019-09-01#7380zikalino merged 4 commits intoAzure:masterfrom
zikalino merged 4 commits intoAzure:masterfrom
Conversation
pilor
added
WaitForARMFeedback
In Testing, Please Ignore[Logs] (Generated from d01dc89, Iteration 4)
|
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpvxxjqrlm/rest/specification/resources/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp0a9crve1'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
majastrz
added
ARMSignedOff
majastrz
approved these changes
Oct 4, 2019
Member
majastrz
left a comment
majastrz
left a comment
There was a problem hiding this comment.
Re-reviewed after latest commit. Still looks good from ARM side.
pilor
removed
the
DoNotMerge
Contributor
Author
|
@myronfanqiu This is ready to merge whenever you get a chance |
mmyyrroonn
approved these changes
Oct 30, 2019
Contributor
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
LGTM. Just left one comment. Since the assignee is @zikalino, I will leave to him to merge this PR.
| "description": "The policy's excluded scopes." | ||
| }, | ||
| "parameters": { | ||
| "type": "object", |
Contributor
There was a problem hiding this comment.
I tried the previous api-version before. For the generated SDK, it's hard to know what is the right structure for this field. Is it possible to add the doc link into the description?
Contributor
Author
There was a problem hiding this comment.
I've changed parameters to an explicit model. If this is too much of a breaking change in downstream SDKs I can revert. However, it will greatly increase quality of life for consumers of the generated code.
.../resources/resource-manager/Microsoft.Authorization/stable/2019-09-01/policyAssignments.json
Show resolved
Hide resolved
zikalino
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare to iteration 1 to see diffs from the previous api-version.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.