Add specs for Available Service Aliases #7362

anton-evseev · 2019-09-30T18:17:36Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-09-30T18:19:36Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpfxdl44do/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpfxdl44do/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[6422:0x4254cc0]    70556 ms: Mark-sweep 1379.3 (1425.3) -> 1379.2 (1425.8) MB, 1134.4 / 0.0 ms  (average mu = 0.187, current mu = 0.066) allocation failure scavenge might not succeed
[6422:0x4254cc0]    72175 ms: Mark-sweep 1380.1 (1425.8) -> 1380.0 (1426.3) MB, 1423.5 / 0.0 ms  (average mu = 0.151, current mu = 0.120) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xfaee06dbe1d]
Security context: 0x0953fd09e6e9 <JSObject>
    1: newScalar [0x288c9296bfc9] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0xfaee0b13116](this=0x26605ac855a9 <Object map = 0x3b05907d9289>,v=0x0e47248826f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x26605ac85d29] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc=...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xfaee06dbe1d

azuresdkci · 2019-09-30T18:31:44Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-30T18:54:44Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

avijitgupta

Approved.

anton-evseev · 2019-10-01T17:24:55Z

@ryansbenson please review from ARM's side

ryansbenson · 2019-10-01T23:08:16Z

...on/network/resource-manager/Microsoft.Network/stable/2019-08-01/availableServiceAliases.json

All fields beyond id, name, type should be inside a 'properties' envelope.

How is resourceName different than name? is there a more descriptive field name you could pick which is self describing?

All fields beyond id, name, type should be inside a 'properties' envelope.

This isn't azure resource but service alias data. Not sure if that should adhere to resource's conventions of nesting properties.

How is resourceName different than name

Resource name is fully-qualified name like /services/Azure/ManagedInstance when name is just resource name without slashes (e.g. servicesAzureManagedInstance)

@avijitgupta should be able to provide more information

Not looking at the name or content of the request, only at the format. This is a Get request on a URL which should be an azure resource. When we do this, it should follow the convention of an azure resource.

"/services/Azure/ManagedInstance" isn't a azure resource name, so it will cause some confusion. Is there a different name we can call it?

@ryansbenson
Below is the logic on the server.
this.Name = resourceName.Replace("/", string.Empty);
this.ResourceName = resourceName;
this.Id = string.Format("/subscriptions/{0}/resourceGroup/{1}/providers/Microsoft.Network/AvailableServiceAliases/{2}", subscriptionId, groupName, this.Name);
this.Type = "Microsoft.Network/AvailableServiceAliases";

Name is the azure resource name which does not have any '/' (it follows the ceonvention of azure resource)
ResourceName is another property which is the alias which the customer is expected to use. Don't expect it to cause confusion.

@ryansbenson one extra thing - this API is already live so we can't change property names or object structure

@avijitgupta - With no change, when a user is told to "Use the resource name to ___", both could be valid interpretations. Why don't you call it "ResourceAlias"? Also, the Id should also include the /location/{location}/ part of the path (the ID should be Get-able).
@number213 - Your RP manifest doesn't have a route for locations/availableServiceAliases yet, so there can't be production traffic going to this path in your service. These reviews are in place to force consistency and catch issues like this before they go live.

There is precedence set with other network APIs with properties outside of the properties body. Though this isn't compliant and will cause issues across ARM tooling, this is understood by the network team.
With regard to resourceName being confusing - it was agreed that a new name, something like 'alias' or 'resourceAlias', should be used but will be changed in a future API version.

openapi-sdkautomation · 2019-10-02T22:36:46Z

In Testing, Please Ignore

[Logs] (Generated from 52d1455, Iteration 2)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Network [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.Network.19.15.0-preview.nupkg
- Microsoft.Azure.Management.Network.19.15.0-preview.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-network [Logs] [Instructions] [Generation PR]
- azure-mgmt-network-5.0.0.zip
- azure_mgmt_network-5.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

No packages generated.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

anton-evseev requested a review from MikhailTryakhov as a code owner September 30, 2019 18:17

anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 30, 2019

azuresdkci assigned tjprescott Sep 30, 2019

azuresdkci requested a review from tjprescott September 30, 2019 18:18

avijitgupta approved these changes Sep 30, 2019

View reviewed changes

ryansbenson reviewed Oct 1, 2019

View reviewed changes

ryansbenson added the ARMChangesRequested label Oct 1, 2019

anton-evseev changed the base branch from network-september-release to master October 2, 2019 22:36

Add specs for availableServiceAliases

52d1455

anton-evseev force-pushed the available-service-aliases branch from 464d464 to 52d1455 Compare October 2, 2019 22:38

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2019

sergey-shandar approved these changes Oct 2, 2019

View reviewed changes

sergey-shandar merged commit 5979f82 into Azure:master Oct 2, 2019

openapi-sdkautomation bot mentioned this pull request Oct 2, 2019

[AutoPR Microsoft.Azure.Management.Network] Add specs for Available Service Aliases test-repo-billy/azure-sdk-for-net#271

Closed

anton-evseev mentioned this pull request Oct 2, 2019

Update Network SDK for September release Azure/azure-sdk-for-net#7891

Merged

jkhurana19 mentioned this pull request Oct 29, 2019

Add az network service-aliases list Azure/azure-cli#11018

Closed

Add specs for Available Service Aliases #7362

Add specs for Available Service Aliases #7362

Uh oh!

Conversation

anton-evseev commented Sep 30, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Sep 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 30, 2019

Uh oh!

AutorestCI commented Sep 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

avijitgupta left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev commented Oct 1, 2019

Uh oh!

ryansbenson Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

ryansbenson Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

avijitgupta Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

ryansbenson Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

ryansbenson Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

openapi-sdkautomation bot commented Oct 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 52d1455, Iteration 2)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AutorestCI commented Sep 30, 2019 •

edited

Loading

AutorestCI commented Sep 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 2, 2019 •

edited

Loading