Skip to content

Added new properties in Invoicing APIs#7341

Merged
raych1 merged 9 commits into
Azure:masterfrom
asarkar84:master
Sep 29, 2019
Merged

Added new properties in Invoicing APIs#7341
raych1 merged 9 commits into
Azure:masterfrom
asarkar84:master

Conversation

@asarkar84
Copy link
Copy Markdown
Contributor

@asarkar84 asarkar84 commented Sep 27, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Sep 27, 2019

In Testing, Please Ignore

[Logs] (Generated from 9380490, Iteration 5)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed billing/resource-manager/v2017_02_27_preview [Logs]
  • Failed billing/resource-manager/v2017_04_24_preview [Logs]
  • Failed billing/resource-manager/v2018_03_01_preview [Logs]
  • Failed billing/resource-manager/v2018_11_01_preview [Logs]
  • Failed billing/resource-manager/v2019_10_01_preview [Logs]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 27, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7483

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 27, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

},
"paymentMethodFamily": {
"description": "The payment method family.",
"type": "string",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an enum-as-string where we document the currently known values?

Copy link
Copy Markdown
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Incorporated review comments
@asarkar84
Copy link
Copy Markdown
Contributor Author

@raych1 Review comments are incorporated. Please review the PR.

@raych1 raych1 merged commit 6ee7fd9 into Azure:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants