Added new properties in Invoicing APIs#7341
Merged
Merged
Conversation
Incorporated review comments
Added new properties in Invoicing APIs
In Testing, Please Ignore[Logs] (Generated from 9380490, Iteration 5)
|
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
wilcobmsft
reviewed
Sep 27, 2019
| }, | ||
| "paymentMethodFamily": { | ||
| "description": "The payment method family.", | ||
| "type": "string", |
Member
There was a problem hiding this comment.
Should this be an enum-as-string where we document the currently known values?
Incorporated review comments
wilcobmsft
approved these changes
Sep 27, 2019
wilcobmsft
approved these changes
Sep 27, 2019
Contributor
Author
|
@raych1 Review comments are incorporated. Please review the PR. |
raych1
approved these changes
Sep 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.