Skip to content

Jit api add justification #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tjprescott merged 5 commits into from
Sep 26, 2019
Merged

Jit api add justification #7298

tjprescott merged 5 commits into from
Sep 26, 2019

Conversation

@Nomigori96MS
Copy link
Contributor

@Nomigori96MS Nomigori96MS commented Sep 24, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 1622131, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/security/mgmt/v1.0 [Logs]
  • In-Progress preview/security/mgmt/v2.0 [Logs]
  • In-Progress preview/security/mgmt/v3.0 [Logs]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 24, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 24, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7377

@AutorestCI AutorestCI mentioned this pull request Sep 24, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 24, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5863

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 24, 2019
Closed
@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 24, 2019

Can one of the admins verify this patch?

@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2019
KrisBash
KrisBash approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2019
@tjprescott tjprescott merged commit f1fdf4a into Azure:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tjprescott tjprescott

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Nomigori96MS @AutorestCI @azuresdkci @tjprescott @KrisBash