Skip to content

Conversation

@ankurkhemani
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 19, 2019

In Testing, Please Ignore

[Logs] (Generated from faa4da7, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7677

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5969

@ankurkhemani ankurkhemani changed the title [ACR] Scope map property updates [ACR][Do Not Merge] Scope map property updates Sep 19, 2019
@lirenhe lirenhe added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 19, 2019
@lirenhe
Copy link
Member

lirenhe commented Sep 19, 2019

@ankurkhemani , please let me know when the PR is ready for merge.

@ankurkhemani ankurkhemani changed the title [ACR][Do Not Merge] Scope map property updates [ACR] Scope map property updates Oct 1, 2019
@ankurkhemani
Copy link
Contributor Author

@zikalino Ready to merge. Thanks!

@lirenhe lirenhe removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 8, 2019
@lirenhe lirenhe merged commit f8d859c into Azure:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants