Initial 2019-09-01-preview for LVA by BrianBlum · Pull Request #7247 · Azure/azure-rest-api-specs

BrianBlum · 2019-09-18T14:06:01Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-18T14:06:05Z

In Testing, Please Ignore

[Logs] (Generated from ae35d5e, Iteration 3)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Media [Logs] [Instructions]
- Microsoft.Azure.Management.Media.2.0.3.nupkg
- Microsoft.Azure.Management.Media.2.0.3.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-media [Logs] [Instructions] [Generation PR]
- azure-mgmt-media-1.1.1.zip
- azure_mgmt_media-1.1.1-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

mediaservices/resource-manager/v2015_10_01 [Logs] [Instructions]
mediaservices/resource-manager/v2018_03_30_preview [Logs] [Instructions]
mediaservices/resource-manager/v2018_06_01_preview [Logs] [Instructions]
mediaservices/resource-manager/v2018_07_01 [Logs] [Instructions]
mediaservices/resource-manager/v2019_05_01_preview [Logs] [Instructions]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

mediaservices/mgmt/2015-10-01 [Logs]
mediaservices/mgmt/2018-07-01 [Logs]
preview/mediaservices/mgmt/2018-03-30-preview [Logs]
preview/mediaservices/mgmt/2018-06-01-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-mediaservices [Logs] [Instructions]
- azure-arm-mediaservices-6.0.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

BrianBlum · 2019-09-18T14:06:38Z

Adding WaitForARMFeedback label for this PR

AutorestCI · 2019-09-18T14:07:12Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2019-09-18T14:08:34Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-18T14:09:05Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

majastrz

Signed off from ARM side.

anuchandy · 2019-09-20T23:08:18Z

...n/mediaservices/resource-manager/Microsoft.Media/preview/2019-09-01-preview/MediaGraphs.json

+      "put": {
+        "summary": "Create or update a Media Graph",
+        "description": "Create or update a Media Graph in the Media Services account",
+        "operationId": "MediaGraphs_CreateOrUpdate",


Is creareOrUpdate a long running operation? same question for delete.

Both PUT (CreateOrUpdate) and DELETE are not long running. They complete synchronously.
In our API, START and STOP actions are Long running operations

anuchandy · 2019-09-20T23:24:50Z

...n/mediaservices/resource-manager/Microsoft.Media/preview/2019-09-01-preview/MediaGraphs.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/mediaServices/{accountName}/mediaGraphs/{mediaGraphName}/operationsStatus/{operationId}": {


Looks like this is to retrieve result of long running operation, if so usually we don't include this operation instead annotate actual LRO operation with x-ms-long-running-operation.

Both long running operations use "x-ms-long-running-operation": true. See line 560 and 608.
As part of long running operation, we return operationId in response header. User can use this API to get operation status.

Initial 2019-09-01-preview for LVA

8b8d717

BrianBlum added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2019

azuresdkci assigned anuchandy Sep 18, 2019

azuresdkci requested a review from anuchandy September 18, 2019 14:07

openapi-sdkautomation bot mentioned this pull request Sep 18, 2019

[AutoPR Microsoft.Azure.Management.Media] Initial 2019-09-01-preview for LVA test-repo-billy/azure-sdk-for-net#216

Merged

Add missing line feeds at eof.

2e1c75c

Remove required property for credentials and update examples.

ae35d5e

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 19, 2019

majastrz approved these changes Sep 19, 2019

View reviewed changes

anuchandy reviewed Sep 20, 2019

View reviewed changes

anuchandy approved these changes Sep 24, 2019

View reviewed changes

anuchandy merged commit 76666f1 into Azure:master Sep 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial 2019-09-01-preview for LVA#7247

Initial 2019-09-01-preview for LVA#7247
anuchandy merged 3 commits intoAzure:masterfrom
BrianBlum:master

BrianBlum commented Sep 18, 2019

Uh oh!

openapi-sdkautomation bot commented Sep 18, 2019 •

edited

Loading

Uh oh!

BrianBlum commented Sep 18, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Sep 18, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Sep 18, 2019

Uh oh!

AutorestCI commented Sep 18, 2019 •

edited

Loading

Uh oh!

majastrz left a comment

Uh oh!

anuchandy Sep 20, 2019

Uh oh!

PrasannaKudli Sep 23, 2019

Uh oh!

anuchandy Sep 20, 2019

Uh oh!

PrasannaKudli Sep 23, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

BrianBlum commented Sep 18, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from ae35d5e, Iteration 3)

Uh oh!

BrianBlum commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AutorestCI commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 18, 2019

Uh oh!

AutorestCI commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

anuchandy Sep 20, 2019

Choose a reason for hiding this comment

Uh oh!

PrasannaKudli Sep 23, 2019

Choose a reason for hiding this comment

Uh oh!

anuchandy Sep 20, 2019

Choose a reason for hiding this comment

Uh oh!

PrasannaKudli Sep 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Sep 18, 2019 •

edited

Loading

BrianBlum commented Sep 18, 2019 •

edited

Loading

AutorestCI commented Sep 18, 2019 •

edited

Loading

AutorestCI commented Sep 18, 2019 •

edited

Loading

PrasannaKudli Sep 23, 2019 •

edited

Loading