Top Level WAF Swagger Changes #7222

venkatsvpr · 2019-09-16T23:13:46Z

Link To Previous PR:
#6851

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-09-16T23:15:48Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpd26qwrxl/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpd26qwrxl/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[11461:0x3336cc0]    73678 ms: Mark-sweep 1377.1 (1426.3) -> 1377.0 (1426.3) MB, 1397.0 / 0.0 ms  (average mu = 0.166, current mu = 0.120) allocation failure GC in old space requested
[11461:0x3336cc0]    75096 ms: Mark-sweep 1377.1 (1426.3) -> 1377.1 (1426.8) MB, 1417.0 / 0.0 ms  (average mu = 0.086, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xec5e7dbe1d]
Security context: 0x01b23de9e6e9 <JSObject>
    1: storeMappingPair(aka storeMappingPair) [0x1d17edf397b1] [/node_modules/yaml-ast-parser/dist/src/loader.js:~270] [pc=0xec5efb749a](this=0x24682ec026f1 <undefined>,state=0x225015d356b1 <State map = 0x3b285a0111f1>,_result=0x19e458046799 <Object map = 0x228f1c51ed99>,keyTag=0x24682ec022b1 <null>,keyNode=0x34d1bf0fff09 <Object map = 0x228f1c51f6e1>,valueNod...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xec5e7dbe1d

azuresdkci · 2019-09-16T23:21:51Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-16T23:50:18Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

anton-evseev

This PR changes specs in 2019-06-01 but it has to target 2019-08-01

venkatsvpr · 2019-09-17T03:23:26Z

@number213 I have done the same. Please check.

...ion/network/resource-manager/Microsoft.Network/stable/2019-08-01/webapplicationfirewall.json

anton-evseev · 2019-09-18T20:15:03Z

@majastrz please review this from ARM's side

...ion/network/resource-manager/Microsoft.Network/stable/2019-08-01/webapplicationfirewall.json

majastrz

There seem to be breaking changes in your PR. I added a comment about this. Please take a look.

anton-evseev · 2019-09-20T19:58:22Z

@majastrz this is a branch for new API version that's not merged into master yet. Could you please approve this PR if there are no other concerns?

anton-evseev · 2019-09-23T19:19:38Z

Per call with @venkatsvpr there may be some changes so adding "do not merge" tag for now

anton-evseev

Please update WafPolicyCreateOrUpdate.json. If you send properties from the current example, you'd get an error:

PS C:\Users\v-anevse> ARMClient.exe PUT /subscriptions/947d47b4-7883-4bb9-9d85-c5e8e2f572ce/resourceGroups/v-anevse/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies/test-policy?api-version=2019-08-01 "{\`"location\`":\`"WestUs\`",\`"properties\`":{\`"customRules\`":[{\`"name\`":\`"Rule1\`",\`"priority\`":1,\`"ruleType\`":\`"MatchRule\`",\`"action\`":\`"Block\`",\`"matchConditions\`":[{\`"matchVariables\`":[{\`"variableName\`":\`"RemoteAddr\`",\`"selector\`":null}],\`"operator\`":\`"IPMatch\`",\`"matchValues\`":[\`"192.168.1.0/24\`",\`"10.0.0.0/24\`"]}]},{\`"name\`":\`"Rule2\`",\`"priority\`":2,\`"ruleType\`":\`"MatchRule\`",\`"matchConditions\`":[{\`"matchVariables\`":[{\`"variableName\`":\`"RemoteAddr\`",\`"selector\`":null}],\`"operator\`":\`"IPMatch\`",\`"matchValues\`":[\`"192.168.1.0/24\`"]},{\`"matchVariables\`":[{\`"variableName\`":\`"RequestHeaders\`",\`"selector\`":\`"UserAgent\`"}],\`"operator\`":\`"Contains\`",\`"matchValues\`":[\`"Windows\`"]}],\`"action\`":\`"Block\`"}]}}"

{
  "error": {
    "code": "ApplicationGatewayFirewallManagedRuleSetsNoValidCrsRuleSetsAttached",
    "message": "Firewall policy /subscriptions/947d47b4-7883-4bb9-9d85-c5e8e2f572ce/resourceGroups/v-anevse/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies/test-policy does not have any valid Core Rule Set attached to it.",
    "details": []
  }
}

anton-evseev

LGTM except one example

...etwork/resource-manager/Microsoft.Network/stable/2019-08-01/examples/WafListAllPolicies.json

anton-evseev · 2019-10-02T00:46:19Z

@tjprescott assigning this to you since Catherine Zhu said you're one of those who would cover for Chinese team during their long holiday. Could you please merge this PR?

sergey-shandar · 2019-10-02T21:11:52Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-08-01/webapplicationfirewall.json

            "$ref": "#/definitions/WebApplicationFirewallCustomRule"
          }
        },
+        "managedRules": {


Add new properties at the end.

* Adds base for updating Microsoft.Network from version stable/2019-07-01 to version 2019-08-01 * Updates readme * Updates API version in new specs and examples * Add reference to Connection Monitor specs in 2019-08-01 (#7218) * Support AH protocol (#7231) * Virtual Network BGP Communities (#7248) * Virtual Wan point to site feature redesign:- (#7238) * Virtual Wan point to site feature redesign * Fix examples * Fix validation errors * Fix validation error * Fix validation errors * Incorporate review comments * Fix default error in standard error response * Fix validation error * Refer to default error from ddos swagger spec * Fix build error * Firewall Manager Feature Swagger Updates for Public Preview (#7266) * Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275) * Revert "Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275)" (#7333) This reverts commit e89f35d. * Virtual network gateway changes for dns forwarding (#7359) * Virtuan network gateway changes for dns forwarding * Fixed example response * Fixed examples * Fixed 201 example * Top-level WAF (#7222) * Move new props to the end to avoid breaking changes in SDK (#7387)

venkatsvpr requested review from MikhailTryakhov and anton-evseev as code owners September 16, 2019 23:13

venkatsvpr changed the title ~~[Do Not Merge] Top Level WAF~~ [DoNotMerge] Top Level WAF Sep 16, 2019

azuresdkci assigned zikalino Sep 16, 2019

azuresdkci requested a review from zikalino September 16, 2019 23:14

venkatsvpr changed the title ~~[DoNotMerge] Top Level WAF~~ [DO NOT MERGE]Top Level WAF Sep 16, 2019

venkatsvpr changed the title ~~[DO NOT MERGE]Top Level WAF~~ [DO NOT MERGE]Top Level WAF Swagger Changes Sep 16, 2019

AutorestCI mentioned this pull request Sep 16, 2019

[AutoPR network/resource-manager] [Do Not Merge] Top Level WAF Azure/azure-sdk-for-go#5785

Closed

anton-evseev suggested changes Sep 16, 2019

View reviewed changes

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 17, 2019

venkatsvpr closed this Sep 17, 2019

venkatsvpr reopened this Sep 17, 2019

anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2019

anton-evseev suggested changes Sep 18, 2019

View reviewed changes

...ion/network/resource-manager/Microsoft.Network/stable/2019-08-01/webapplicationfirewall.json Show resolved Hide resolved

venkatsvpr changed the title ~~[DO NOT MERGE]Top Level WAF Swagger Changes~~ Top Level WAF Swagger Changes Sep 18, 2019

anton-evseev removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 18, 2019

majastrz reviewed Sep 18, 2019

View reviewed changes

...ion/network/resource-manager/Microsoft.Network/stable/2019-08-01/webapplicationfirewall.json Show resolved Hide resolved

majastrz added the ARMChangesRequested label Sep 18, 2019

majastrz requested changes Sep 18, 2019

View reviewed changes

anton-evseev approved these changes Sep 20, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 21, 2019

majastrz approved these changes Sep 21, 2019

View reviewed changes

venkatsvpr changed the title ~~Top Level WAF Swagger Changes~~ [DoNotMerge] Top Level WAF Swagger Changes Sep 23, 2019

anton-evseev added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 23, 2019

anton-evseev suggested changes Sep 24, 2019

View reviewed changes

venkatsvpr changed the title ~~[DoNotMerge] Top Level WAF Swagger Changes~~ Top Level WAF Swagger Changes Oct 1, 2019

anton-evseev removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 1, 2019

anton-evseev suggested changes Oct 1, 2019

View reviewed changes

...etwork/resource-manager/Microsoft.Network/stable/2019-08-01/examples/WafListAllPolicies.json Show resolved Hide resolved

Top-level WAF

ef1537f

anton-evseev force-pushed the network-september-release branch from 35f33f2 to ef1537f Compare October 2, 2019 00:19

anton-evseev approved these changes Oct 2, 2019

View reviewed changes

anton-evseev assigned tjprescott and unassigned zikalino Oct 2, 2019

sergey-shandar added the potential-sdk-breaking-change label Oct 2, 2019

sergey-shandar reviewed Oct 2, 2019

View reviewed changes

tjprescott merged commit f8a5884 into Azure:network-september-release Oct 2, 2019

Top Level WAF Swagger Changes #7222

Top Level WAF Swagger Changes #7222

Uh oh!

Conversation

venkatsvpr commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 16, 2019

Uh oh!

AutorestCI commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

venkatsvpr commented Sep 17, 2019

Uh oh!

Uh oh!

anton-evseev commented Sep 18, 2019

Uh oh!

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev commented Sep 20, 2019

Uh oh!

anton-evseev commented Sep 23, 2019

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anton-evseev commented Oct 2, 2019

Uh oh!

sergey-shandar Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

venkatsvpr commented Sep 16, 2019 •

edited

Loading

AutorestCI commented Sep 16, 2019 •

edited

Loading

AutorestCI commented Sep 16, 2019 •

edited

Loading