Skip to content

Conversation

@eschwabe
Copy link
Contributor

@eschwabe eschwabe commented Sep 16, 2019

Overview

  • Add defaultAction and defaultState to managed rule set definitions
  • No API version change since only impact is to read-only API

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [X ] I have reviewed the documentation for the workflow.
  • [X ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [X ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2019

In Testing, Please Ignore

[Logs] (Generated from 3fa8f35, Iteration 3)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7303

@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5820

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 17, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM sign off

@KrisBash KrisBash added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 18, 2019
@lirenhe lirenhe removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2019
@lirenhe lirenhe merged commit 2ed8788 into Azure:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants