Skip to content

[Hub Generated] Review request for Microsoft.Kusto to add version stable/2019-09-07 #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lirenhe merged 7 commits into from
Sep 19, 2019
Merged

[Hub Generated] Review request for Microsoft.Kusto to add version stable/2019-09-07 #7219

lirenhe merged 7 commits into from
Sep 19, 2019

Conversation

@saguiitay
Copy link
Contributor

@saguiitay saguiitay commented Sep 16, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 67a8ba3, Iteration 5)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed kusto/resource-manager/v2018_09_07_preview [Logs]
  • Failed kusto/resource-manager/v2019_01_21 [Logs]
  • Failed kusto/resource-manager/v2019_05_15 [Logs]
  • Failed kusto/resource-manager/v2019_09_07 [Logs]

@saguiitay saguiitay added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 16, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7300

@AutorestCI AutorestCI mentioned this pull request Sep 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5828

@saguiitay
Copy link
Contributor Author

saguiitay commented Sep 16, 2019

Swagger was already approved in Private repository;

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 16, 2019
Closed
@majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 16, 2019
majastrz
majastrz approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 16, 2019

Can one of the admins verify this patch?

lirenhe
lirenhe reviewed Sep 17, 2019
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed Sep 18, 2019
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed Sep 18, 2019
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed Sep 18, 2019
View reviewed changes
ArcturusZhang
ArcturusZhang requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the output-folder in readme.go.md file.

@saguiitay
Update readme.go.md
67a8ba3 
Updated output-folder (removed `stable`)
@saguiitay saguiitay removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 18, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 18, 2019
Merged
@lirenhe lirenhe merged commit fcda278 into Azure:master Sep 19, 2019
@liatbezalel liatbezalel mentioned this pull request Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lirenhe lirenhe lirenhe approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@majastrz majastrz majastrz approved these changes

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@saguiitay @AutorestCI @azuresdkci @lirenhe @ArcturusZhang @majastrz @sergey-shandar