Add new version for Microsoft.Solutions #7212

dandanwang0320 · 2019-09-13T22:36:13Z

Update to the latest api version.
Move Jit request changes to this PR.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Please diff later commits with this one for the changes.

Add Jit requests. Try fix Model validation.

openapi-sdkautomation · 2019-09-13T22:36:16Z

In Testing, Please Ignore

[Logs] (Generated from 15cad4f, Iteration 4)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs]

No packages generated.

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

features/resource-manager/v2015_12_01 [Logs] [Generation PR]
locks/resource-manager/v2016_09_01 [Logs]
policy/resource-manager/v2016_12_01 [Logs]
policy/resource-manager/v2018_03_01 [Logs]
policy/resource-manager/v2018_05_01 [Logs]
policy/resource-manager/v2019_01_01 [Logs]
policy/resource-manager/v2019_06_01 [Logs]
resources/resource-manager/v2016_06_01 [Logs]
resources/resource-manager/v2016_09_01 [Logs]
resources/resource-manager/v2018_02_01 [Logs]
resources/resource-manager/v2018_06_01 [Logs]
resources/resource-manager/v2019_03_01 [Logs]
resources/resource-manager/v2019_05_01 [Logs]
resources/resource-manager/v2019_05_10 [Logs]
resources/resource-manager/v2019_06_01 [Logs]
resources/resource-manager/v2019_07_01 [Logs]
resources/resource-manager/v2019_08_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/resources/mgmt/2015-10-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2015-10-01-preview.zip
preview/resources/mgmt/2016-09-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2016-09-01-preview.zip
preview/resources/mgmt/2017-06-01-preview [Logs] [Instructions] [Generation PR]
- preview.resources.mgmt.2017-06-01-preview.zip
resources/mgmt/2015-01-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-01-01.zip
resources/mgmt/2015-11-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-11-01.zip
resources/mgmt/2015-12-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2015-12-01.zip
resources/mgmt/2016-02-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-02-01.zip
resources/mgmt/2016-04-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-04-01.zip
resources/mgmt/2016-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-06-01.zip
resources/mgmt/2016-07-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-07-01.zip
resources/mgmt/2016-09-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-09-01.zip
resources/mgmt/2016-12-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2016-12-01.zip
resources/mgmt/2017-05-10 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2017-05-10.zip
resources/mgmt/2017-09-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2017-09-01.zip
resources/mgmt/2018-02-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-02-01.zip
resources/mgmt/2018-03-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-03-01.zip
resources/mgmt/2018-05-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-05-01.zip
resources/mgmt/2018-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2018-06-01.zip
resources/mgmt/2019-01-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-01-01.zip
resources/mgmt/2019-03-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-03-01.zip
resources/mgmt/2019-05-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-05-01.zip
resources/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-06-01.zip
resources/mgmt/2019-07-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-07-01.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-managedapplications [Logs] [Instructions]
- azure-arm-managedapplications-1.0.2.tgz
@azure/arm-policy [Logs] [Instructions]
- azure-arm-policy-2.0.0.tgz
@azure/arm-resources [Logs] [Instructions]
- azure-arm-resources-2.1.0.tgz

AutorestCI · 2019-09-13T22:38:52Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8406

AutorestCI · 2019-09-13T22:40:54Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6315

azuresdkci · 2019-09-13T22:58:10Z

Can one of the admins verify this patch?

yungezz · 2019-09-16T01:33:36Z

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

+          "Applications"
+        ],
+        "operationId": "Applications_CreateOrUpdate",
+        "description": "Creates a new managed application.",


Create or Update per operationId?

Sorry these are just copied from the old version. Could you ignore the first commit during review?

yungezz · 2019-09-16T01:35:04Z

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

+          "Applications"
+        ],
+        "operationId": "Applications_ListByResourceGroup",
+        "description": "Gets all the applications within a resource group.",


List all...

This is also from the old version.

yungezz · 2019-09-16T01:35:57Z

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

+        }
+      }
+    },
+    "/{applicationId}": {


/subscriptions/{subscriptionId}/providers/Microsoft.Solutions/applications/{applicationId} ?

This is the fully qualified application Id. Also it's from the old version.

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

yungezz · 2019-09-23T01:56:55Z

Hi @dandanwang0320 could you pls address comments from reviewing board?

yungezz · 2019-10-08T03:05:49Z

Hi @dandanwang0320 are you still on this PR? or is it ok to close the PR if you're not ready for reviewing?

dandanwang0320 · 2019-10-09T22:31:34Z

@yungezz Yes. I replied some of your comments. Synced with Bryan offline for some necessary changes needed within ARM code.

yungezz · 2019-10-10T01:31:44Z

HI @ryansbenson could you pls review the PR again after author's updating?

dandanwang0320 · 2019-10-21T23:08:08Z

Will add more API/Properties as I'm fixing Ryan's comments.

dandanwang0320 · 2019-11-01T01:00:07Z

Hi @ryansbenson, I've resolved your comments and added several more resources to the new version to keep this updated.
Please take another look.

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

Remove update access since it should be internal only(used by PIM team)

dandanwang0320 · 2019-11-05T01:22:19Z

@pilor I've responded/fixed the comments you left. We decided to remove one of the APIs since it's facing internal customers only(updateAccess).

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json

yungezz · 2019-11-07T02:48:14Z

@dandanwang0320 is this PR ready to merge?

dandanwang0320 · 2019-11-07T22:16:38Z

@dandanwang0320 is this PR ready to merge?

Let's do it next Monday. Is it Ok?

Edit:
Back end change is finished. This PR is ready to merge now.

…need a swagger.

* First commit for new version folder with old files Please diff later commits with this one for the changes. * Update version. Add Jit requests. Try fix Model validation. * Update operation Id * Operations read, refresh permission, PR comments. * Application definition artifact. * Fix build * Fix build * Jit Patch * Post async 202 * Fix example model valiation. * Fix PR comments. Remove update access since it should be internal only(used by PIM team) * Capitalization to fix build. * Read only properties * Removed application definition artifact, which is internal and don't need a swagger.

dandanwang0320 added 2 commits September 13, 2019 14:40

First commit for new version folder with old files

140a2dd

Please diff later commits with this one for the changes.

Update version.

5ef52b9

Add Jit requests. Try fix Model validation.

dandanwang0320 requested a review from Tiano2017 as a code owner September 13, 2019 22:36

AutorestCI mentioned this pull request Sep 13, 2019

[AutoPR resources/resource-manager] Add new version for Microsoft.Solutions Azure/azure-sdk-for-python#7265

Closed

AutorestCI mentioned this pull request Sep 13, 2019

[AutoPR resources/resource-manager] Add new version for Microsoft.Solutions Azure/azure-sdk-for-go#5770

Closed

Update operation Id

15cad4f

azuresdkci assigned yungezz Sep 13, 2019

azuresdkci requested a review from yungezz September 13, 2019 22:59

yungezz reviewed Sep 16, 2019

View reviewed changes

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019

ryansbenson added the ARMReviewInProgress label Sep 18, 2019

ryansbenson reviewed Sep 18, 2019

View reviewed changes

ryansbenson added ARMChangesRequested and removed ARMReviewInProgress labels Sep 18, 2019

dandanwang0320 changed the title ~~Add new version for Microsoft.Solutions~~ [Do not review]Add new version for Microsoft.Solutions Oct 21, 2019

openapi-sdkautomation bot mentioned this pull request Oct 21, 2019

[AutoPR features/resource-manager/v2015_12_01] [Do not review]Add new version for Microsoft.Solutions test-repo-billy/azure-sdk-for-java#738

Closed

dandanwang0320 added 3 commits October 31, 2019 13:38

Operations read, refresh permission, PR comments.

8358d68

Application definition artifact.

5a88b6a

Fix build

9a677d1

AutorestCI mentioned this pull request Oct 31, 2019

[AutoPR resources/resource-manager] [Do not review]Add new version for Microsoft.Solutions Azure/azure-sdk-for-go#6213

Closed

Fix build

05f37a7

dandanwang0320 added 2 commits October 31, 2019 16:24

Jit Patch

9b514e6

Post async 202

19b01d8

dandanwang0320 changed the title ~~[Do not review]Add new version for Microsoft.Solutions~~ Add new version for Microsoft.Solutions Nov 1, 2019

Fix example model valiation.

74a26cc

pilor suggested changes Nov 1, 2019

View reviewed changes

Fix PR comments.

a91d692

Remove update access since it should be internal only(used by PIM team)

This was referenced Nov 5, 2019

[AutoPR resources/resource-manager] Add new version for Microsoft.Solutions Azure/azure-sdk-for-python#8386

Closed

[AutoPR resources/resource-manager] Add new version for Microsoft.Solutions Azure/azure-sdk-for-go#6253

Merged

Capitalization to fix build.

88ed326

pilor suggested changes Nov 5, 2019

View reviewed changes

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json Show resolved Hide resolved

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json Show resolved Hide resolved

Read only properties

5be1da0

pilor approved these changes Nov 5, 2019

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 5, 2019

dandanwang0320 requested a review from yungezz November 6, 2019 20:18

yungezz approved these changes Nov 7, 2019

View reviewed changes

Removed application definition artifact, which is internal and don't …

98cefa2

…need a swagger.

raych1 merged commit 8e86c2f into Azure:master Nov 12, 2019

Add new version for Microsoft.Solutions #7212

Add new version for Microsoft.Solutions #7212

Uh oh!

Conversation

dandanwang0320 commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 15cad4f, Iteration 4)

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Sep 13, 2019

Uh oh!

yungezz Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

dandanwang0320 Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

dandanwang0320 Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

dandanwang0320 Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yungezz commented Sep 23, 2019

Uh oh!

yungezz commented Oct 8, 2019

Uh oh!

dandanwang0320 commented Oct 9, 2019

Uh oh!

yungezz commented Oct 10, 2019

Uh oh!

dandanwang0320 commented Oct 21, 2019

Uh oh!

dandanwang0320 commented Nov 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dandanwang0320 commented Nov 5, 2019

Uh oh!

Uh oh!

Uh oh!

yungezz commented Nov 7, 2019

Uh oh!

dandanwang0320 commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dandanwang0320 commented Sep 13, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading

dandanwang0320 commented Nov 7, 2019 •

edited

Loading