Aro 2019-09-30 preview API Version by JackQuincy · Pull Request #7211 · Azure/azure-rest-api-specs

JackQuincy · 2019-09-13T22:16:46Z

Adding swagger spec for the newest API Version for ARO.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-13T22:16:49Z

In Testing, Please Ignore

[Logs] (Generated from aa9913e, Iteration 13)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-containerservice [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-mgmt-containerservice-7.0.0.zip
- azure_mgmt_containerservice-7.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

containerservice/resource-manager/v2019_06_01 [Logs] [Instructions]
containerservice/resource-manager/v2019_08_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

containerservice/mgmt/2017-07-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-07-01.zip
containerservice/mgmt/2017-08-31 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-08-31.zip
containerservice/mgmt/2017-09-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-09-30.zip
containerservice/mgmt/2018-03-31 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2018-03-31.zip
containerservice/mgmt/2019-02-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-02-01.zip
containerservice/mgmt/2019-04-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-04-30.zip
containerservice/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-06-01.zip
containerservice/mgmt/2019-08-01 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2019-08-01.zip
preview/containerservice/mgmt/2018-08-01-preview [Logs] [Instructions] [Generation PR] [Integration PR]
- preview.containerservice.mgmt.2018-08-01-preview.zip
preview/containerservice/mgmt/2018-09-30-preview [Logs] [Instructions] [Generation PR] [Integration PR]
- preview.containerservice.mgmt.2018-09-30-preview.zip
preview/containerservice/mgmt/2019-09-30-preview [Logs] [Instructions] [Generation PR] [Integration PR]
- preview.containerservice.mgmt.2019-09-30-preview.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-containerservice [Logs]

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.ContainerService [Logs] [Instructions] [Generation PR] [Integration PR]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

azuresdkci · 2019-09-13T22:17:35Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-13T22:18:04Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7596

AutorestCI · 2019-09-13T22:19:27Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5958

...-manager/Microsoft.ContainerService/preview/2019-09-30-preview/openShiftManagedClusters.json

raych1 · 2019-09-16T01:41:27Z

@JackQuincy, please copy the previous version API swagger as first commit then work on top of it for the new change when adding new API version. It will be easier for the review on the new change. Another thing, it's better to have the folder name called as ...nerService/preview/2019-09-30/... without literal preview after API version so that it will be easier to move the exact whole folder to stable version.

KrisBash

I compared with 2018-09-30 preview, and the actual API changes seem fine. I think the only required fix is the version property in the swagger spec

KrisBash · 2019-09-18T20:35:41Z

...resource-manager/Microsoft.ContainerService/preview/2019-09-30/openShiftManagedClusters.json

+  "info": {
+    "title": "ContainerServiceClient",
+    "description": "The Container Service Client.",
+    "version": "2019-04-30"


Version does not match folder name or PR title.

Thanks. I'll fix this soon

JackQuincy · 2019-09-18T20:59:03Z

Internally we have decided to add an enabled disabled flag here as well so that we can allow the user to remove the logging integration. And that change is waiting on our partner team in redhat. Once that is finalized I'll update this pr. Should be by EOW

…ersion that is being added

JackQuincy · 2019-09-26T18:09:04Z

took a little longer then expected but this is now updated with the final schema for this version and ready for review

JackQuincy · 2019-09-26T19:44:46Z

@raych1 this is ready for review again sorry for the long time between revisions

raych1 · 2019-09-27T01:27:58Z

...ager/Microsoft.ContainerService/preview/2019-09-30/examples/OpenShiftManagedClustersGet.json

          },
          "monitorProfile": {
-            "workspaceResourceID": "/subscriptions/subid1/resourcegroups/rg1/providers/Microsoft.OperationalInsights/workspaces/workspacename1"
+          "enabled": true,


Please correct indent.

raych1 · 2019-09-27T02:02:00Z

specification/containerservice/resource-manager/readme.python.md

+
+### Tag: package-2019-09-preview-only and python
+
+These settings apply only when `--tag=package-2019-08-preview-only --python` is specified on the command line.


copy paste error. fixing

raych1 · 2019-09-27T02:02:46Z

@KrisBash , please review the changes, thanks.

KrisBash

LGTM

JackQuincy · 2019-10-03T22:22:54Z

@raych1 this should be ready for review again. Sorry for slow turn around.

Jack Quincy added 2 commits September 12, 2019 17:25

adding swagger spec for api version 2019-09-30-preview

10a3f11

adding the datamodel update

87d2679

updating readmes for new api version

377cff4

azuresdkci assigned raych1 Sep 13, 2019

azuresdkci requested a review from raych1 September 13, 2019 23:01

adding input file for 2019-09-30-preview tag

f66a8dd

AutorestCI mentioned this pull request Sep 13, 2019

[AutoPR containerservice/resource-manager] Aro 2019-09-30 preview API Version Azure/azure-sdk-for-python#7267

Closed

fixing spelling mistake

d40c07c

openapi-sdkautomation bot mentioned this pull request Sep 13, 2019

[AutoPR Microsoft.Azure.Management.ContainerService] Aro 2019-09-30 preview API Version test-repo-billy/azure-sdk-for-net#200

Merged

AutorestCI mentioned this pull request Sep 13, 2019

[AutoPR containerservice/resource-manager] Aro 2019-09-30 preview API Version Azure/azure-sdk-for-go#5772

Closed

openapi-sdkautomation bot mentioned this pull request Sep 13, 2019

[AutoPR containerservice/resource-manager/v2019_06_01] Aro 2019-09-30 preview API Version test-repo-billy/azure-sdk-for-java#386

Closed

raych1 reviewed Sep 16, 2019

View reviewed changes

...-manager/Microsoft.ContainerService/preview/2019-09-30-preview/openShiftManagedClusters.json Show resolved Hide resolved

raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019

Jack Quincy added 3 commits September 17, 2019 16:50

copying current version to new folder

3eec9ac

deleting preview named file and moving changes to the new version folder

bc678f6

removing -preview file per pull request comments

c962b08

KrisBash added the ARMReviewInProgress label Sep 18, 2019

KrisBash reviewed Sep 18, 2019

View reviewed changes

KrisBash added ARMChangesRequested and removed ARMReviewInProgress labels Sep 18, 2019

Jack Quincy added 3 commits September 18, 2019 15:16

changing api version in the apiverion definition file to be the api v…

d4b5c0f

…ersion that is being added

adding enabled flag

7293488

update create_update example

6308fd2

raych1 requested a review from KrisBash September 27, 2019 01:21

raych1 reviewed Sep 27, 2019

View reviewed changes

KrisBash approved these changes Oct 2, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2019

fixing typo and indentation

aa9913e

This was referenced Oct 3, 2019

[AutoPR containerservice/resource-manager] Aro 2019-09-30 preview API Version Azure/azure-sdk-for-python#7595

Merged

[AutoPR containerservice/resource-manager] Aro 2019-09-30 preview API Version Azure/azure-sdk-for-go#5946

Merged

openapi-sdkautomation bot mentioned this pull request Oct 3, 2019

[AutoPR Microsoft.Azure.Management.ContainerService] Aro 2019-09-30 preview API Version test-repo-billy/azure-sdk-for-net#274

Merged

raych1 approved these changes Oct 7, 2019

View reviewed changes

raych1 merged commit a390b90 into Azure:master Oct 7, 2019


		### Tag: package-2019-09-preview-only and python

		These settings apply only when `--tag=package-2019-08-preview-only --python` is specified on the command line.

Conversation

JackQuincy commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from aa9913e, Iteration 13)

Uh oh!

azuresdkci commented Sep 13, 2019

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

raych1 commented Sep 16, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

KrisBash Sep 18, 2019

Choose a reason for hiding this comment

Uh oh!

JackQuincy Sep 18, 2019

Choose a reason for hiding this comment

Uh oh!

JackQuincy commented Sep 18, 2019

Uh oh!

JackQuincy commented Sep 26, 2019

Uh oh!

JackQuincy commented Sep 26, 2019

Uh oh!

raych1 Sep 27, 2019

Choose a reason for hiding this comment

Uh oh!

raych1 Sep 27, 2019

Choose a reason for hiding this comment

Uh oh!

JackQuincy Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

raych1 commented Sep 27, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

JackQuincy commented Oct 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JackQuincy commented Sep 13, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading