Amaga/update customer policy by amagams · Pull Request #7210 · Azure/azure-rest-api-specs

amagams · 2019-09-13T20:56:11Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-13T20:56:15Z

In Testing, Please Ignore

[Logs] (Generated from a48d205, Iteration 8)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]

Package generation in progress.

AutorestCI · 2019-09-13T20:57:01Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7310

azuresdkci · 2019-09-13T20:58:03Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-13T20:58:36Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

wilcobmsft · 2019-09-15T03:41:17Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

        }
      }
+    },
+	"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default": {


Remove /billingProfiles/{billingProfileName}. The "home" resource container for customers is /providers/Microsoft.Billing/billingAccounts/{billingAccountName}/customers.

wilcobmsft · 2019-09-15T03:42:11Z

...urce-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/UpdateCustomerPolicy.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/policies/default",


/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/customers/{customerName}/policies/default

wilcobmsft · 2019-09-15T03:42:29Z

...urce-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/UpdateCustomerPolicy.json

+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/policies/default",
+        "name": "default",
+        "type": "Microsoft.Billing/billingAccounts/billingProfiles/policies",


Microsoft.Billing/billingAccounts/customers/policies

wilcobmsft · 2019-09-15T03:42:45Z

...g/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/CustomerPolicy.json

+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default",
+        "name": "default",
+        "type": "Microsoft.Billing/billingAccounts/billingProfiles/customers/policies",


Microsoft.Billing/billingAccounts/customers/policies

wilcobmsft · 2019-09-15T03:43:11Z

...g/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/CustomerPolicy.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default",


drop /billingProfiles/{billingProfileName}

wilcobmsft · 2019-09-15T03:43:33Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

+            "$ref": "#/parameters/billingAccountNameParameter"
+          },
+          {
+            "$ref": "#/parameters/billingProfileNameParameter"


remove billingProfileNameParameter

wilcobmsft · 2019-09-15T03:43:42Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

+            "$ref": "#/parameters/billingAccountNameParameter"
+          },
+          {
+            "$ref": "#/parameters/billingProfileNameParameter"


amagams

Applying Code review feedback, mostly around removing billing profile name in the path.

amagams · 2019-09-16T18:25:22Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

        }
      }
+    },
+	"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default": {


amagams · 2019-09-16T18:25:54Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

+            "$ref": "#/parameters/billingAccountNameParameter"
+          },
+          {
+            "$ref": "#/parameters/billingProfileNameParameter"


amagams · 2019-09-16T18:26:00Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

+            "$ref": "#/parameters/billingAccountNameParameter"
+          },
+          {
+            "$ref": "#/parameters/billingProfileNameParameter"


amagams · 2019-09-16T18:26:28Z

...g/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/CustomerPolicy.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default",


amagams · 2019-09-16T18:26:47Z

...g/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/CustomerPolicy.json

+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/customers/{customerName}/policies/default",
+        "name": "default",
+        "type": "Microsoft.Billing/billingAccounts/billingProfiles/customers/policies",


amagams · 2019-09-16T18:28:12Z

...urce-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/UpdateCustomerPolicy.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/policies/default",


amagams · 2019-09-16T18:28:37Z

...urce-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/UpdateCustomerPolicy.json

+      "body": {
+        "id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/policies/default",
+        "name": "default",
+        "type": "Microsoft.Billing/billingAccounts/billingProfiles/policies",


...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

majastrz · 2019-09-16T21:28:44Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

      }
+    },
+	"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/customers/{customerName}/policies/default": {
+      "get": {


get [](start = 7, length = 3)

I noticed that there's no delete support here. Does the resource always exist? (As in GET always returns a successful response?)

Yes, this resource always exist

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

majastrz

Please add the GET collection route and take a look at the questions I added to the PR.

majastrz

Signed off from ARM side.

amagams added 4 commits September 13, 2019 11:28

duplicate

f76db3f

examples remaining

1f21132

update the policy definition

f2c897f

Adding examples

041a564

amagams requested a review from wilcobmsft as a code owner September 13, 2019 20:56

azuresdkci assigned anuchandy Sep 13, 2019

azuresdkci requested a review from anuchandy September 13, 2019 20:57

amagams added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2019

adding updatecustomerpolicy.json example file

74c6216

This was referenced Sep 15, 2019

[AutoPR Microsoft.Azure.Management.Billing] Amaga/update customer policy test-repo-billy/azure-sdk-for-net#202

Merged

[AutoPR billing/resource-manager/v2017_02_27_preview] Amaga/update customer policy test-repo-billy/azure-sdk-for-java#389

Closed

wilcobmsft reviewed Sep 15, 2019

View reviewed changes

Applying Code review feedbacks

a48d205

amagams commented Sep 16, 2019

View reviewed changes

wilcobmsft approved these changes Sep 16, 2019

View reviewed changes

anuchandy approved these changes Sep 16, 2019

View reviewed changes

majastrz reviewed Sep 16, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Show resolved Hide resolved

majastrz reviewed Sep 16, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Show resolved Hide resolved

majastrz added the ARMChangesRequested label Sep 16, 2019

majastrz requested changes Sep 16, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 16, 2019

majastrz approved these changes Sep 16, 2019

View reviewed changes

anuchandy merged commit 69674f9 into master Sep 16, 2019

AutorestCI mentioned this pull request Sep 16, 2019

[AutoPR billing/resource-manager] Amaga/update customer policy Azure/azure-sdk-for-python#7310

Closed

JackTn deleted the amaga/updateCustomerPolicy branch August 9, 2021 10:10

Conversation

amagams commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from a48d205, Iteration 8)

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 13, 2019

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amagams left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

amagams commented Sep 13, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading