Skip to content

Replace common domain in examples.#7198

Merged
weidongxu-microsoft merged 4 commits intoAzure:masterfrom
LTA-Thinking:master
Sep 13, 2019
Merged

Replace common domain in examples.#7198
weidongxu-microsoft merged 4 commits intoAzure:masterfrom
LTA-Thinking:master

Conversation

@LTA-Thinking
Copy link
Contributor

The common domain used in the examples is not supported by our service. It has been replaced with a valid GUID to allow the examples to be run successfully.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [ x ] I have reviewed the documentation for the workflow.
  • [ x ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [ x ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Pooja Adhikari and others added 4 commits August 19, 2019 10:56
@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 12, 2019

In Testing, Please Ignore

[Logs] (Generated from 7a35ba9, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed healthcareapis/resource-manager/v2018_08_20_preview [Logs] [Generation PR]
  • Failed healthcareapis/resource-manager/v2019-09-16 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning healthcareapis/mgmt/2019-09-16 [Logs]
  • Warning preview/healthcareapis/mgmt/2018-08-20-preview [Logs]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@weidongxu-microsoft weidongxu-microsoft merged commit af5ce4c into Azure:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants