Skip to content

Add item to AttackTactic enum #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 1 commit into from
Sep 20, 2019
Merged

Add item to AttackTactic enum #7197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,7 +2365,8 @@
"LateralMovement",
"Collection",
"Exfiltration",
"CommandAndControl"
"CommandAndControl",
Copy link
Copy Markdown
Contributor

@ryansbenson ryansbenson Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a preview API this is ok. This wouldn't be a breaking change if modelAsString was true, consider changing this in the GA version.
https://microsoft.sharepoint.com/:w:/t/azureresourcemanagerteam/EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw?e=xEcppo

"Impact"
],
"type": "string",
"x-ms-enum": {
Expand Down