Skip to content

Update ManagedNetwork#7192

Merged
tjprescott merged 3 commits intoAzure:masterfrom
yanfa317:master
Sep 12, 2019
Merged

Update ManagedNetwork#7192
tjprescott merged 3 commits intoAzure:masterfrom
yanfa317:master

Conversation

@yanfa317
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 12, 2019

In Testing, Please Ignore

[Logs] (Generated from e5677a9, Iteration 3)

Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@yanfa317
Copy link
Contributor Author

1, Restructure tags from list of string to single object.
2, reframe the space in managedNetwork.json

@yanfa317
Copy link
Contributor Author

It is only be internal tested in limited area, and it is not released to outside cusomters.

@yanfa317
Copy link
Contributor Author

@azuresdkci This patch is used to upate structure of Tags in ManagedNetwork. I verify it.

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the indent changes back to 2 spaces instead of 4. It's unclear if these changes are merely fixes or are adding new things.

@yanfa317
Copy link
Contributor Author

@nschonni @tjprescott I have reverted the space change, please review it again. Thanks!

@tjprescott tjprescott merged commit 4aba8b5 into Azure:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants