Conversation
In Testing, Please Ignore[Logs] (Generated from e5677a9, Iteration 3)
|
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Contributor
Author
|
1, Restructure tags from list of string to single object. |
Contributor
Author
|
It is only be internal tested in limited area, and it is not released to outside cusomters. |
Contributor
Author
|
@azuresdkci This patch is used to upate structure of Tags in ManagedNetwork. I verify it. |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
nschonni
reviewed
Sep 12, 2019
...ork/resource-manager/Microsoft.ManagedNetwork/preview/2019-06-01-preview/managedNetwork.json
Show resolved
Hide resolved
tjprescott
requested changes
Sep 12, 2019
Member
tjprescott
left a comment
There was a problem hiding this comment.
Please revert the indent changes back to 2 spaces instead of 4. It's unclear if these changes are merely fixes or are adding new things.
Contributor
Author
|
@nschonni @tjprescott I have reverted the space change, please review it again. Thanks! |
tjprescott
approved these changes
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.