Skip to content

Cases API Deprecation Note#7187

Merged
erich-wang merged 3 commits intoAzure:masterfrom
dosegal:CasesDeprecationNote
Sep 16, 2019
Merged

Cases API Deprecation Note#7187
erich-wang merged 3 commits intoAzure:masterfrom
dosegal:CasesDeprecationNote

Conversation

@dosegal
Copy link
Copy Markdown
Contributor

@dosegal dosegal commented Sep 11, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 11, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from f3a3631, Iteration 6)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7275

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5703

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 11, 2019

Can one of the admins verify this patch?

@nschonni
Copy link
Copy Markdown
Contributor

nschonni commented Sep 11, 2019

Should "deprecated": true be used instead?

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 12, 2019
@erich-wang
Copy link
Copy Markdown
Member

erich-wang commented Sep 12, 2019

although preview doesn't necessary apply to deprecation policy, add ARM review team to double confirm.

@dosegal
Copy link
Copy Markdown
Contributor Author

dosegal commented Sep 12, 2019 •
edited
Loading

Should "deprecated": true be used instead?

@nschonni thanks, changed

KrisBash
KrisBash approved these changes Sep 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2019
@erich-wang erich-wang merged commit a6c827e into Azure:master Sep 16, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KrisBash KrisBash KrisBash approved these changes

@erich-wang erich-wang erich-wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dosegal @AutorestCI @azuresdkci @nschonni @erich-wang @KrisBash