Skip to content

Changed swagger to fit the new return value from actions controller#7171

Merged
erich-wang merged 3 commits intoAzure:masterfrom
YuvalShilo-Microsoft:master
Sep 20, 2019
Merged

Changed swagger to fit the new return value from actions controller#7171
erich-wang merged 3 commits intoAzure:masterfrom
YuvalShilo-Microsoft:master

Conversation

@YuvalShilo-Microsoft
Copy link
Copy Markdown
Contributor

@YuvalShilo-Microsoft YuvalShilo-Microsoft commented Sep 10, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 10, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 406eff2, Iteration 3)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Sep 10, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7275

@AutorestCI AutorestCI mentioned this pull request Sep 10, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5803

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 10, 2019

Can one of the admins verify this patch?

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 11, 2019
shschwar
shschwar reviewed Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@shschwar shschwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
NIT - Could please just update the trigger URI comment to be more accurate.
from: "The uri for the action to trigger " --> to "Logic App Callback URL".

KrisBash
KrisBash suggested changes Sep 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change within api version

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
"ActionResponseProperties": {
"description": "Action property bag.",
"properties": {
"workflowId": {
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a breaking change. It should go in a new API version

Copy link
Copy Markdown
Contributor Author

@YuvalShilo-Microsoft YuvalShilo-Microsoft Sep 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our product is still in preview, that's why we are doing these changes now..
we don't think there should be a new API version.

KrisBash
KrisBash approved these changes Sep 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off after offline discussion

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 19, 2019
@erich-wang erich-wang merged commit 91f7643 into Azure:master Sep 20, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erich-wang erich-wang Awaiting requested review from erich-wang

2 more reviewers

@shschwar shschwar shschwar left review comments

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuvalShilo-Microsoft @AutorestCI @azuresdkci @KrisBash @shschwar @erich-wang