Adding the specs for GA version of Events API by srinathgrs · Pull Request #7134 · Azure/azure-rest-api-specs

srinathgrs · 2019-09-05T18:54:43Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-05T18:54:45Z

In Testing, Please Ignore

[Logs] (Generated from 10ffd47, Iteration 24)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

resourcehealth/mgmt/2015-01-01 [Logs]
resourcehealth/mgmt/2017-07-01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

No packages generated.

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

resourcehealth/resource-manager/v2015_01_01 [Logs]
resourcehealth/resource-manager/v2017_07_01 [Logs]
resourcehealth/resource-manager/v2018_08_01_preview [Logs]

.NET: test-repo-billy/azure-sdk-for-net [Logs]

No packages generated.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

AutorestCI · 2019-09-05T18:55:56Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-09-05T18:56:46Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-09-05T19:15:03Z

Can one of the admins verify this patch?

nschonni

occured -> occurred

...sourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2018-07-01/ResourceHealth.json

...er/Microsoft.ResourceHealth/stable/2018-07-01/examples/AvailabilityStatus_GetByResource.json

...e-manager/Microsoft.ResourceHealth/stable/2018-07-01/examples/AvailabilityStatuses_List.json

...soft.ResourceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListByResourceGroup.json

...oft.ResourceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListBySubscriptionId.json

...rosoft.ResourceHealth/stable/2018-07-01/examples/ImpactedResources_ListBySubscriptionId.json

…ceHealth/stable/2018-07-01/ResourceHealth.json fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatus_GetByResource.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_List.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/ResourceHealth.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_List.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListByResourceGroup.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/ImpactedResources_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListByResourceGroup.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

KrisBash

Events looks good. Please see questions regarding impacted resources

...sourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2018-07-01/ResourceHealth.json

...rosoft.ResourceHealth/stable/2018-07-01/examples/ImpactedResources_ListBySubscriptionId.json

...sourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2018-07-01/ResourceHealth.json

Impacted resources still in preview , not a GA candidate

srinathgrs · 2019-09-19T17:15:49Z

I have updated the review based on the review comments , Could you please continue reviewing

KrisBash

LGTM thanks

srinathgrs · 2019-09-24T17:18:01Z

LGTM thanks

Thanks , Looks like i dont have access to merge this pull request . Will it be merged by the ARM team or should i raise a request to get access

Adding the specs for GA version of events api

83f4f73

azuresdkci assigned michaeljqzq Sep 5, 2019

azuresdkci requested a review from michaeljqzq September 5, 2019 18:55

Updating readme with 2018-07-01

be2f1ba

nschonni reviewed Sep 6, 2019

View reviewed changes

srinathgrs and others added 11 commits September 10, 2019 10:58

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

4784d7a

…ceHealth/stable/2018-07-01/ResourceHealth.json fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

b040d18

…ceHealth/stable/2018-07-01/examples/AvailabilityStatus_GetByResource.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

69d9c71

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_List.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

3ea3e3c

…ceHealth/stable/2018-07-01/ResourceHealth.json Fixing typo Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

4c8558e

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_List.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

62e3af4

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListByResourceGroup.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

e71d592

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

7b87ebe

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

6ce42dc

…ceHealth/stable/2018-07-01/examples/ImpactedResources_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

ade9b4b

…ceHealth/stable/2018-07-01/examples/ImpactedResources_ListBySubscriptionId.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

Update specification/resourcehealth/resource-manager/Microsoft.Resour…

230d8cd

…ceHealth/stable/2018-07-01/examples/AvailabilityStatuses_ListByResourceGroup.json Typo errors fixed Co-Authored-By: Nick Schonning <nschonni@gmail.com>

michaeljqzq added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 11, 2019

KrisBash reviewed Sep 13, 2019

View reviewed changes

KrisBash added ARMChangesRequested labels Sep 13, 2019

srinathgrs requested a review from KrisBash September 17, 2019 16:34

srinathgrs added 2 commits September 18, 2019 11:57

Removing impacted resources

ba44496

Impacted resources still in preview , not a GA candidate

Correcting the version

9f3d058

Removing unused example files

10ffd47

KrisBash approved these changes Sep 24, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2019

michaeljqzq merged commit 5bcca1f into Azure:master Sep 26, 2019

kazrael2119 mentioned this pull request May 19, 2023

resourcehealth release Azure/azure-sdk-for-js#25847

Merged

Conversation

srinathgrs commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 10ffd47, Iteration 24)

Uh oh!

AutorestCI commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Sep 5, 2019

Uh oh!

nschonni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srinathgrs commented Sep 19, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

srinathgrs commented Sep 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

srinathgrs commented Sep 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 5, 2019 •

edited

Loading

AutorestCI commented Sep 5, 2019 •

edited

Loading

AutorestCI commented Sep 5, 2019 •

edited

Loading