Skip to content

Adding kinds for AlertRules endpoints, updating AlertRuleTemplates endpoints#7130

Merged
yaohaizh merged 11 commits intoAzure:masterfrom
yoshkedi:master
Sep 18, 2019
Merged

Adding kinds for AlertRules endpoints, updating AlertRuleTemplates endpoints#7130
yaohaizh merged 11 commits intoAzure:masterfrom
yoshkedi:master

Conversation

@yoshkedi
Copy link
Copy Markdown
Contributor

@yoshkedi yoshkedi commented Sep 5, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 5, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 9ec455b, Iteration 3)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from yaohaizh September 5, 2019 09:46
@AutorestCI AutorestCI mentioned this pull request Sep 5, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7275

@AutorestCI AutorestCI mentioned this pull request Sep 5, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5803

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 5, 2019

Can one of the admins verify this patch?

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 6, 2019
pilor
pilor suggested changes Sep 9, 2019
View reviewed changes
@pilor pilor added ARMChangesRequested ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2019
@yoshkedi yoshkedi requested a review from pilor September 15, 2019 08:50
@yaohaizh yaohaizh merged commit 5ace989 into Azure:master Sep 18, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@nirgfani nirgfani nirgfani left review comments

@pilor pilor pilor approved these changes

@yaohaizh yaohaizh yaohaizh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yaohaizh yaohaizh

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yoshkedi @AutorestCI @azuresdkci @pilor @yaohaizh @nirgfani