Panwang/taskruns by pan-wang · Pull Request #7123 · Azure/azure-rest-api-specs

pan-wang · 2019-09-05T00:13:24Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-05T00:13:27Z

In Testing, Please Ignore

[Logs] (Generated from d0215e3, Iteration 8)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]

Package generation in progress.

AutorestCI · 2019-09-05T00:15:23Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8722

AutorestCI · 2019-09-05T00:17:34Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6395

azuresdkci · 2019-09-05T00:36:38Z

Can one of the admins verify this patch?

anuchandy

Looks good from SDK side. Requested ARM review as it adds new APIs.

KrisBash

Please see comments

...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json

KrisBash · 2019-09-13T00:49:40Z

...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsCreate.json

+        "type": "Microsoft.ContainerRegistry/registries/TaskRuns",
+        "properties": {
+            "provisioningState": "Creating",
+            "runRequest": {


As described above, the swagger spec doesn't document this schema or the other types.

yungezz · 2019-10-08T03:32:00Z

hi @pan-wang could you pls address comments ?

pan-wang · 2019-10-08T20:46:30Z

Thank so much for remaindering. We are working on twitting the change for better ARM deployment experience. Will address all feedbacks soon once we land on final change. Thanks Pan

…

________________________________ From: Yunge Zhu <notifications@github.com> Sent: Monday, October 7, 2019 11:32 PM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: pan-wang <pan-wang@hotmail.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Panwang/taskruns (#7123) hi @pan-wang<https://github.com/pan-wang> could you pls address comments ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#7123?email_source=notifications&email_token=AEKUVW7X75CINWR4D35NII3QNP5NJA5CNFSM4ITX26M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASQXII#issuecomment-539298721>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEKUVW3F7SCAWTDESRLVROTQNP5NJANCNFSM4ITX26MQ>.

majastrz

@KrisBash's comments have not been addressed and are blocking approval. Please fix.

huanwu · 2019-11-09T01:32:02Z

@KrisBash Could we move forward for this PR? We would like to file a separate work item to solve the debt per discussion above. And there're two Ignore Test-Only CI fail. We can just ignore, right?

...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsCreate.json

majastrz · 2019-11-09T08:05:24Z

@krishbabu Could we move forward for this PR? We would like to file a separate work item to solve the debt per discussion above. And there're two Ignore Test-Only CI fail. We can just ignore, right?

I think you meant @KrisBash. For the CI failures, @anuchandy will need to weigh as the SDK team owns these checks.

majastrz

Looks good to me. I'll leave it for @KrisBash to do the final sign off since his comments are still remaining.

ravbhatnagar

@pan-wang - one comment, please take a look. ALso some from Kris have not been addressed.

ravbhatnagar · 2019-11-13T21:41:01Z

...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json

this is not the right schema for error. sample here - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/batch/resource-manager/Microsoft.Batch/stable/2019-08-01/BatchManagement.json#L105

@ravbhatnagar Just submitted a new commit to solve the problem

ravbhatnagar · 2019-11-14T22:53:09Z

Signing off from ARM side.

huanwu · 2019-11-14T22:57:32Z

@majastrz ARM signed off this change. Could you continue merge the manifest?

huanwu · 2019-11-15T05:27:56Z

@anuchandy Could you merge the PR? The manifest update was blocked now.

azuresdkci assigned anuchandy Sep 5, 2019

azuresdkci requested a review from anuchandy September 5, 2019 00:14

AutorestCI mentioned this pull request Sep 5, 2019

[AutoPR containerregistry/resource-manager] Panwang/taskruns Azure/azure-sdk-for-python#7068

Closed

AutorestCI mentioned this pull request Sep 5, 2019

[AutoPR containerregistry/resource-manager] Panwang/taskruns Azure/azure-sdk-for-go#5697

Closed

openapi-sdkautomation bot mentioned this pull request Sep 5, 2019

[AutoPR containerregistry/resource-manager/v2016_06_27_preview] Panwang/taskruns test-repo-billy/azure-sdk-for-java#337

Closed

openapi-sdkautomation bot mentioned this pull request Sep 6, 2019

[AutoPR Microsoft.Azure.Management.ContainerRegistry] Panwang/taskruns test-repo-billy/azure-sdk-for-net#178

Closed

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 11, 2019

anuchandy approved these changes Sep 11, 2019

View reviewed changes

KrisBash suggested changes Sep 13, 2019

View reviewed changes

KrisBash added the ARMChangesRequested label Sep 13, 2019

majastrz requested changes Nov 7, 2019

View reviewed changes

This was referenced Nov 8, 2019

[AutoPR containerregistry/resource-manager] Panwang/taskruns Azure/azure-sdk-for-python#8542

Closed

[AutoPR containerregistry/resource-manager] Panwang/taskruns Azure/azure-sdk-for-go#6303

Merged

majastrz reviewed Nov 9, 2019

View reviewed changes

...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsCreate.json Outdated Show resolved Hide resolved

majastrz approved these changes Nov 9, 2019

View reviewed changes

ravbhatnagar reviewed Nov 13, 2019

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2019

Pan Wang and others added 19 commits November 18, 2019 15:06

fix typo

71e6f86

update naming

ed89dee

Remove default response from swagger

626158e

add type

446f5d6

update samples

df72ec7

update samples

68d4f7b

update delete sample

26b9d2b

Add default error response

442f09b

add missing }

fb16e73

add missing type

4e22c92

Remove readonly

e42e2b9

Revert RunRequest changes.

98cd663

Revert changes for these two files.

40305db

Update error response format

461fdf4

Update error description

0677008

Add ErrorSchema

c4c5ff3

Solve conflict

f73cfe9

revert changes.

3a60482

Add ErrorSchema

fca508d

huanwu force-pushed the panwang/taskruns branch from 095677d to fca508d Compare November 18, 2019 23:08

Update style based on prettier check.

f14a1fb

huanwu force-pushed the panwang/taskruns branch from 216765f to f14a1fb Compare November 19, 2019 00:16

huanwu and others added 2 commits November 18, 2019 16:27

Merge branch 'master' into panwang/taskruns

de5c0f2

fix style

df2feec

AutorestCI mentioned this pull request Nov 19, 2019

[AutoPR containerregistry/resource-manager] Panwang/taskruns Azure/azure-sdk-for-python#8722

Closed

anuchandy approved these changes Nov 19, 2019

View reviewed changes

yungezz merged commit 65862ac into Azure:master Nov 20, 2019

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019

Panwang/taskruns (Azure#7123)

89abfbb

Conversation

pan-wang commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from d0215e3, Iteration 8)

Uh oh!

AutorestCI commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Sep 5, 2019

Uh oh!

anuchandy left a comment

Choose a reason for hiding this comment

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KrisBash Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz commented Oct 8, 2019

Uh oh!

pan-wang commented Oct 8, 2019 via email

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

huanwu commented Nov 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

majastrz commented Nov 9, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

huanwu Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Nov 14, 2019

Uh oh!

huanwu commented Nov 14, 2019

Uh oh!

huanwu commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Comments

pan-wang commented Sep 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 5, 2019 •

edited

Loading

AutorestCI commented Sep 5, 2019 •

edited

Loading

AutorestCI commented Sep 5, 2019 •

edited

Loading

huanwu commented Nov 9, 2019 •

edited

Loading