DataBox Edge - Rename from edgegateway to databoxedge, added a new version of API by anponnet · Pull Request #7115 · Azure/azure-rest-api-specs

anponnet · 2019-09-04T05:37:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Rename edgegateway to databoxedge, create new version of API Co-Authored-By: Arun Ramachandran <arramach@microsoft.com>

…pecs

Correcting readme scripts

openapi-sdkautomation · 2019-09-04T05:37:58Z

In Testing, Please Ignore

[Logs] (Generated from 5927195, Iteration 14)

azuresdkci · 2019-09-04T05:38:22Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-04T05:38:37Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5780

AutorestCI · 2019-09-04T05:39:01Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7287

nschonni

You'll need to update the ignore for the misspelled "Fulfilment" for the old version if you're renaming the file

azure-rest-api-specs/cSpell.json

Lines 572 to 576 in 1cf4036

    
               "filename": "**/specification/edgegateway/resource-manager/Microsoft.DataBoxEdge/stable/2019-03-01/edgegateway.json", 
        
               "words": [ 
        
                   "Fulfilment" 
        
               ] 
        
           },

nschonni · 2019-09-05T05:19:06Z

...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-07-01/databoxedge.json

+            "$ref": "./examples/UploadCertificatePost.json"
+          }
+        }
+


Fulfilment -> Fulfillment

Suggested change

"enum": [ "Untracked", "AwaitingFulfillment", "AwaitingPreparation", "AwaitingShipment", "Shipped", "Arriving", "Delivered", "ReplacementRequested", "LostDevice", "Declined", "ReturnInitiated", "AwaitingReturnShipment", "ShippedBack", "CollectedAtMicrosoft" ],

lirenhe · 2019-09-09T03:13:12Z

@anponnet , there are a couple of tool check errors in this PR, could you help to fix the Avocado error which is required for the merge (public.rest-api-specs (Avocado) Failing after 6m — Avocado failed )?

KrisBash

Reviewed changes in the new version vs 2019-03-01. LGTM

lirenhe · 2019-09-16T02:48:36Z

@anponnet , please take a look at the tool validation error in https://dev.azure.com/azure-sdk/public/_build/results?buildId=110606&view=logs&j=f10f5372-40ed-54fc-caa4-b1cb5bd1252b and https://dev.azure.com/azure-sdk/public/_build/results?buildId=110606&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742

anponnet · 2019-09-16T10:51:57Z

@anponnet , please take a look at the tool validation error in https://dev.azure.com/azure-sdk/public/_build/results?buildId=110606&view=logs&j=f10f5372-40ed-54fc-caa4-b1cb5bd1252b and https://dev.azure.com/azure-sdk/public/_build/results?buildId=110606&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742

@lirenhe I have fixed the validation errors and tests are passed. Can you please review

nschonni · 2019-09-17T05:00:35Z

@lirenhe the spellcheck was flagging a typo in the Enum value. It was suppressed on the old version (but not fixed with the rename). Not sure the new version should be merged/released without fixing that

PhoenixHe-NV · 2019-09-17T05:06:24Z

@anponnet Would you please fix the spellcheck error https://github.com/Azure/azure-rest-api-specs/pull/7115/checks?check_run_id=223623035

anponnet · 2019-09-17T05:11:40Z

@anponnet Would you please fix the spellcheck error https://github.com/Azure/azure-rest-api-specs/pull/7115/checks?check_run_id=223623035

@phoenix We have to release a new version of API to fix it. We will fix it and send a new CR with updated version

anponnet and others added 8 commits March 5, 2019 12:00

Corrected comments of trigger and extendedinfo APIs, corrected examples

48ab04d

Microsoft.DataBoxEdge RP: Have better examples

a412196

Corrected parameter description in order API

86db25b

Fix: Flattening payload if number of properties is less or equals 2

a63cb28

Rename edgegateway to databoxedge, create new version of API

13f1e88

Rename edgegateway to databoxedge, create new version of API Co-Authored-By: Arun Ramachandran <arramach@microsoft.com>

Merge branch 'master' of https://github.com/anponnet/azure-rest-api-s…

686d44d

…pecs

Correcting readme scripts

468546c

Correcting readme scripts

Corrected the out folder for SDKs

098048f

azuresdkci assigned lirenhe Sep 4, 2019

azuresdkci requested a review from lirenhe September 4, 2019 05:39

nschonni reviewed Sep 5, 2019

View reviewed changes

lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 9, 2019

KrisBash approved these changes Sep 13, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2019

PhoenixHe-NV closed this Sep 16, 2019

PhoenixHe-NV reopened this Sep 16, 2019

anponnet added 2 commits September 16, 2019 14:18

Update readme.md

85f483f

Correcting namespace in 2019-03 version before adding 2019-07

36b3202

anponnet added 3 commits September 16, 2019 14:59

Delete UpdateSummaryPost.json

b842a6a

Correcting examples

292ba1f

Update TriggerPut.json

dcb8e5e

anponnet added 3 commits September 16, 2019 15:36

Correcting examples

36a7ef2

Update readme.md

9ba1c7a

Adding new version of API

5927195

anponnet closed this Sep 16, 2019

anponnet reopened this Sep 16, 2019

AutorestCI mentioned this pull request Sep 16, 2019

[AutoPR databoxedge/resource-manager/edgegateway/resource-manager] DataBox Edge - Rename from edgegateway to databoxedge, added a new version of API Azure/azure-sdk-for-go#5780

Merged

lirenhe approved these changes Sep 17, 2019

View reviewed changes

lirenhe merged commit a917b27 into Azure:master Sep 17, 2019

	"filename": "**/specification/edgegateway/resource-manager/Microsoft.DataBoxEdge/stable/2019-03-01/edgegateway.json",
	"words": [
	"Fulfilment"
	]
	},


	"enum": [ "Untracked", "AwaitingFulfillment", "AwaitingPreparation", "AwaitingShipment", "Shipped", "Arriving", "Delivered", "ReplacementRequested", "LostDevice", "Declined", "ReturnInitiated", "AwaitingReturnShipment", "ShippedBack", "CollectedAtMicrosoft" ],

Conversation

anponnet commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 5927195, Iteration 14)

Uh oh!

azuresdkci commented Sep 4, 2019

Uh oh!

AutorestCI commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

nschonni left a comment

Choose a reason for hiding this comment

Uh oh!

nschonni Sep 5, 2019

Choose a reason for hiding this comment

Uh oh!

lirenhe commented Sep 9, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

lirenhe commented Sep 16, 2019

Uh oh!

anponnet commented Sep 16, 2019

Uh oh!

nschonni commented Sep 17, 2019

Uh oh!

PhoenixHe-NV commented Sep 17, 2019

Uh oh!

anponnet commented Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anponnet commented Sep 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 4, 2019 •

edited

Loading

AutorestCI commented Sep 4, 2019 •

edited

Loading

AutorestCI commented Sep 4, 2019 •

edited

Loading