Skip to content

Conversation

@docohe
Copy link
Contributor

@docohe docohe commented Sep 2, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2019

In Testing, Please Ignore

[Logs] (Generated from 8264dcc, Iteration 2)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed kusto/resource-manager/v2018_09_07_preview [Logs]
  • Failed kusto/resource-manager/v2019_01_21 [Logs]
  • Failed kusto/resource-manager/v2019_05_15 [Logs]

@AutorestCI
Copy link

AutorestCI commented Sep 2, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7070

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 2, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5700

@docohe
Copy link
Contributor Author

docohe commented Sep 2, 2019

Please let me know before merging

@yungezz
Copy link
Member

yungezz commented Sep 3, 2019

@docohe when is this PR ready to merge? Just to double confirm, this is not a breaking change to customer?

@docohe
Copy link
Contributor Author

docohe commented Sep 3, 2019

@yungezz We can merge. This is not breaking change, just adding new data format type that the customer can use.

@yungezz
Copy link
Member

yungezz commented Sep 3, 2019

@yungezz We can merge. This is not breaking change, just adding new data format type that the customer can use.

ok to merge it now? or waiting for your notification?

@docohe
Copy link
Contributor Author

docohe commented Sep 3, 2019

@yungezz you can merge.

@docohe
Copy link
Contributor Author

docohe commented Sep 4, 2019

Any updates on the merge ?

@yungezz yungezz merged commit 95869c4 into Azure:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants