Compute 2019-07-01 version by hyonholee · Pull Request #7094 · Azure/azure-rest-api-specs

hyonholee · 2019-08-31T01:59:52Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-31T01:59:55Z

In Testing, Please Ignore

[Logs] (Generated from 4c1f44f, Iteration 34)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Compute [Logs] [Instructions]
- Microsoft.Azure.Management.Compute.29.1.0.nupkg
- Microsoft.Azure.Management.Compute.29.1.0.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-compute [Logs] [Instructions] [Generation PR]
- azure-mgmt-compute-8.0.0.zip
- azure_mgmt_compute-8.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

compute/resource-manager/v2017_03_30 [Logs]
compute/resource-manager/v2017_09_01 [Logs]
compute/resource-manager/v2017_12_01 [Logs]
compute/resource-manager/v2018_04_01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-compute [Logs] [Instructions]
- azure-arm-compute-11.0.0.tgz

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

compute/mgmt/2015-06-15 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2015-06-15.zip
compute/mgmt/2016-03-30 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2016-03-30.zip
compute/mgmt/2017-03-30 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-03-30.zip
compute/mgmt/2017-09-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-09-01.zip
compute/mgmt/2017-12-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-12-01.zip
compute/mgmt/2018-04-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-04-01.zip
compute/mgmt/2018-06-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-06-01.zip
compute/mgmt/2018-10-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-10-01.zip
compute/mgmt/2019-03-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2019-03-01.zip
compute/mgmt/2019-07-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2019-07-01.zip
containerservice/mgmt/2016-03-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2016-03-30.zip
containerservice/mgmt/2016-09-30 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2016-09-30.zip
containerservice/mgmt/2017-01-31 [Logs] [Instructions] [Generation PR]
- containerservice.mgmt.2017-01-31.zip
preview/compute/mgmt/2016-04-30-preview [Logs] [Instructions] [Generation PR]
- preview.compute.mgmt.2016-04-30-preview.zip
preview/containerservice/mgmt/2015-11-01-preview [Logs] [Instructions] [Generation PR]
- preview.containerservice.mgmt.2015-11-01-preview.zip

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-08-31T02:03:23Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8068

AutorestCI · 2019-08-31T02:08:33Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6091

azuresdkci · 2019-08-31T03:02:25Z

Can one of the admins verify this patch?

hyonholee · 2019-09-11T18:37:40Z

@zikalino Could you check why model validation fails in this PR? Thanks

zikalino · 2019-09-12T18:32:16Z

specification/compute/resource-manager/readme.md

      - ACS service is deprecated so a PATCH endpoint won't be implemented

 ```
+### Tag: package-2019-07


i think we shoudl just update existing tag instead of creating a new one, or any particular reason for new one?

zikalino · 2019-09-12T18:47:08Z

The reason for failure is:

publicipaddressconfiguration in CreateAScaleSetWithAnAzureLoadBalancer.json

…into compute-2019-07

…-api-specs into compute-2019-07

…ute.

zikalino · 2019-10-17T01:37:09Z

@hyonholee so we need to disable these validation errors

qiaozha · 2019-10-17T05:47:43Z

@hyonholee For errors in LintDiff, if you'd like to suppress these validation errors, you may refer to specification/compute/resource-manager/readme.md of this repo and add them to the suppress part.

hyonholee · 2019-10-17T18:30:28Z

@qiaozha @zikalino Thanks, I updated readme.md file to suppress the errors.

KrisBash

All swagger API specs should have a "default" response with a response body aligned to standard error contract. Can we at least add that in new/changed APIs?

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/disk.json

hyonholee · 2019-10-19T22:13:29Z

@KrisBash I added default responses to the new APIs.

KrisBash

LGTM thanks

hyonholee requested a review from huangpf as a code owner August 31, 2019 01:59

hyonholee added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 31, 2019

openapi-sdkautomation bot mentioned this pull request Aug 31, 2019

[AutoPR compute/resource-manager/v2017_03_30] [DO NOT MERGE] Compute 2019-07-01 version test-repo-billy/azure-sdk-for-java#320

Closed

azuresdkci assigned zikalino Aug 31, 2019

azuresdkci requested a review from zikalino August 31, 2019 02:32

hyonholee force-pushed the compute-2019-07 branch 3 times, most recently from c470556 to b697336 Compare September 10, 2019 01:03

openapi-sdkautomation bot mentioned this pull request Sep 10, 2019

[AutoPR Microsoft.Azure.Management.Compute] [DO NOT MERGE] Compute 2019-07-01 version test-repo-billy/azure-sdk-for-net#187

Closed

hyonholee force-pushed the compute-2019-07 branch 2 times, most recently from 01c84c3 to 1307bde Compare September 11, 2019 01:54

zikalino reviewed Sep 12, 2019

View reviewed changes

hyonholee requested review from Tiano2017, solankisamir and v-Ajnava as code owners September 12, 2019 21:35

openapi-sdkautomation bot mentioned this pull request Sep 12, 2019

[AutoPR Microsoft.Azure.Management.ApiManagement] [DO NOT MERGE] Compute 2019-07-01 version test-repo-billy/azure-sdk-for-net#197

Merged

hyonholee force-pushed the compute-2019-07 branch 2 times, most recently from dff17a9 to 0d2974f Compare September 12, 2019 22:12

hyonholee and others added 3 commits September 17, 2019 11:29

Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

d8f768e

changes to add publicIpAddressVersion field (#7173)

f29c97d

temp fix

6faf3ed

hyonholee requested review from DavidLiCIG, MikhailTryakhov and hitenjava as code owners September 17, 2019 19:01

sds6 and others added 4 commits October 15, 2019 23:13

add update property (#7514)

e19fed2

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

9c8588b

…into compute-2019-07

Merge branch 'compute-2019-07' of https://github.com/Azure/azure-rest…

d445604

…-api-specs into compute-2019-07

Sync with the latest 2019-03-01 version to 2019-07-01 version of comp…

43849d3

…ute.

hyonholee assigned erich-wang Oct 16, 2019

zikalino added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 17, 2019

suppress LintDiff validation error.

b4fd7e2

KrisBash suggested changes Oct 18, 2019

View reviewed changes

KrisBash added the ARMChangesRequested label Oct 18, 2019

hyonholee force-pushed the compute-2019-07 branch 3 times, most recently from a6358d4 to 5e46bff Compare October 19, 2019 21:43

Add default responses to new APIs.

b70af91

hyonholee force-pushed the compute-2019-07 branch from 5e46bff to b70af91 Compare October 19, 2019 21:55

KrisBash approved these changes Oct 19, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 19, 2019

zikalino approved these changes Oct 20, 2019

View reviewed changes

zikalino merged commit 4a26ffa into master Oct 20, 2019

This was referenced Oct 21, 2019

[AutoPR compute/resource-manager] Compute 2019-07-01 version Azure/azure-sdk-for-python#8068

Closed

[AutoPR compute/resource-manager] Compute 2019-07-01 version Azure/azure-sdk-for-go#6091

Merged

hyonholee mentioned this pull request Oct 22, 2019

[Compute] 2019-07-01 API version update Azure/azure-sdk-for-net#8319

Merged

ramankumarlive mentioned this pull request Oct 23, 2019

Storage server side encryption with customer managed keys for managed disks Azure/azure-cli#10948

Closed

hyonholee deleted the compute-2019-07 branch April 21, 2020 18:12

Conversation

hyonholee commented Aug 31, 2019 • edited by qwordy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 4c1f44f, Iteration 34)

Uh oh!

AutorestCI commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Aug 31, 2019

Uh oh!

hyonholee commented Sep 11, 2019

Uh oh!

zikalino Sep 12, 2019

Choose a reason for hiding this comment

Uh oh!

zikalino commented Sep 12, 2019

Uh oh!

zikalino commented Oct 17, 2019

Uh oh!

qiaozha commented Oct 17, 2019

Uh oh!

hyonholee commented Oct 17, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyonholee commented Oct 19, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Comments

hyonholee commented Aug 31, 2019 •

edited by qwordy

Loading

openapi-sdkautomation bot commented Aug 31, 2019 •

edited

Loading

AutorestCI commented Aug 31, 2019 •

edited

Loading

AutorestCI commented Aug 31, 2019 •

edited

Loading