Estebanreyl/data plane 08 2019 #7060

estebanreyl · 2019-08-28T05:14:08Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps. **_- Definitely tried it, never seems to leave the "still working" screen. Will update when I try again tomorrow but every other validator has succeeded.

As a note a few linting issues could not be resolved as they are intrinsic in handling compatibility with docker or OCI's own expectations for registry API's I will also be following up in email as described in https://github.com/Azure/adx-documentation-pr/wiki/Swagger-Validation-Errors-Suppression

This is a Preview Release for the ACR runtime data-plane API specification
This should be a fully functional release to address: #6773. As an important note to this one, my internship is coming to an end next week and I still need to get this through before making a PR to the .NET SDK repository. I would really appreciate it if we could get this looked at quickly.

Changes:

Added support for most of our Blob end point API's
HEAD (General and For chunks), GET (General and For chunks), DELETE /v2/{name}/blobs/{digest}
POST (Mount from Repository), POST (Start upload) /v2/{name}/blobs/uploads/
PATCH , PUT, GET, DELETE /v2/{name}/blobs/uploads/{uuid} # Note uses some trickery to improve user experience as these require a Location link instead of parameters (As the parameters can only be obtained by parsing the Location link)
Added Support for OCI Manifests, Manifest Lists, and OCI Index. Models are defined for each.
Renamed many functions to use cleaner names.

Bugfixes:

Cleaned up the entire swagger file re-using parameters and definition references
Fixed improper use of 32 bit numbers for storing the size of certain items like layer sizes. Since some layers can exceed this size this resulted in inaccurate measurements.

All paths have been verified and the generated client has been tested as well in C#. This should ideally lead to a release of a fully functioning .NET SDK.

…iety of bugs

This reverts commit 18deb78.

openapi-sdkautomation · 2019-08-28T05:14:11Z

In Testing, Please Ignore

[Logs] (Generated from ef66280, Iteration 7)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/containerregistry/runtime/2019-07 [Logs]

AutorestCI · 2019-08-28T05:15:14Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-08-28T05:17:11Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-08-28T05:33:25Z

Can one of the admins verify this patch?

yungezz · 2019-08-28T06:18:43Z

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json

+            "$ref": "./examples/GetDockerRegistryV2Support.json"
+          }
+        },
+        "operationId": "CheckV2Support",


operationId naming convention: Resource_Action

I've updated this for all items in question.

yungezz · 2019-08-28T06:18:58Z

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json

+            "$ref": "./examples/GetManifest.json"
+          }
+        },
+        "operationId": "GetManifest",


operationId naming convention: Resource_Action

yungezz · 2019-08-28T06:19:28Z

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json

+        "consumes": [
+          "application/vnd.docker.distribution.manifest.v2+json"
+        ],
+        "operationId": "CreateManifest",


same as above

yungezz · 2019-08-28T06:20:28Z

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json

+              }
+            }
+          },
+          "307": {


normally not put return code other than 2xx in swagger. need ARM feedback.

yungezz · 2019-08-28T06:23:08Z

...lane/Microsoft.ContainerRegistry/preview/2019-08-15/examples/UpdateRepositoryAttributes.json

+    }
+  },
+  "responses": {
+    "200": {}


empty response body?

That method doesn't return anything in fact. Only the status code is relevant. Adding an empty reponse body seems to bring a warning in oav.

estebanreyl · 2019-08-29T00:49:51Z

Its not immediately evident to me why the pipeline tests may be failing. Looking at the results it seems like they crash on th semantic validation. Any ideas?

…e issue.

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json

estebanreyl · 2019-08-30T02:30:51Z

As a note there should be no need for an Azure REST API review board to review as described in: #6629 (comment) . This follows as the API is already in production.

estebanreyl · 2019-08-30T21:22:07Z

I don't want to be pushy, but I am unfortunately running out of time here, any updates on this front?

yungezz · 2019-09-02T02:40:24Z

Hi @johanste , could you pls help to review the PR? thanks.

Related to Azure#7060

* fix: cspell failures Related to #7060 * fix: Additional spelling issues from #6902

Esteban Rey added 20 commits August 14, 2019 17:21

Begin clean branch without changes (To facilitate later review)

72d575f

Added all blob path work to the date.

6cd556d

Further changes to naming and execution

20e53ec

Began adding support for multiple manifest types

f895fa7

Claning up manifest items

a67af0b

Cleanup name

f755f13

Added full OCI, and OCI Index manifest support as well as fixed a var…

24d9927

…iety of bugs

Added more generic Descriptor type to support OCI descriptors as well.

48ee6fb

Cleaned up names

7c66ffe

Further name cleanup

931d2b5

More renaming

f186096

Further Fixes

3884c99

Added Updated Content-Range header generation exception.

d08e04e

Adds internal fixes for improper header use in C#

fa2aca9

Fixes code generation to support V2 Location link

47d4e43

Rmoves all Specified blob requests given nextLink now works perfectly

422ffbd

Merge with upstream

18deb78

Preparing for release, cleaning up syntax issues. Only examples missing.

6b549a6

Cleanup and fixes required for proper generation

3a3afeb

Revert "Merge with upstream"

ef28e52

This reverts commit 18deb78.

azuresdkci assigned yungezz Aug 28, 2019

azuresdkci requested a review from yungezz August 28, 2019 05:14

yungezz reviewed Aug 28, 2019

View reviewed changes

yungezz added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Aug 28, 2019

Esteban Rey added 2 commits August 28, 2019 10:51

Removed unused examples and generated new names as per convention

2ea6315

Fix Model Warning issues

bb7d6f1

Esteban Rey added 2 commits August 29, 2019 10:33

Removed higher scope parameter definitions, to attempt fixing pipelin…

9c829d2

…e issue.

Small cleanup in x-ms-examples descriptions

9ed166a

mnltejaswini reviewed Aug 29, 2019

View reviewed changes

...nerregistry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json Outdated Show resolved Hide resolved

Updated description of one method for consistency

ef66280

yungezz assigned johanste Sep 2, 2019

yungezz approved these changes Sep 2, 2019

View reviewed changes

yungezz merged commit 255757f into Azure:master Sep 2, 2019

nschonni added a commit to nschonni/azure-rest-api-specs that referenced this pull request Sep 2, 2019

fix: cspell failures

200548b

Related to Azure#7060

erich-wang pushed a commit that referenced this pull request Sep 3, 2019

fix: cspell failures (#7099)

459d7b1

* fix: cspell failures Related to #7060 * fix: Additional spelling issues from #6902

Estebanreyl/data plane 08 2019 #7060

Estebanreyl/data plane 08 2019 #7060

Uh oh!

Conversation

estebanreyl commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

Uh oh!

openapi-sdkautomation bot commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from ef66280, Iteration 7)

Uh oh!

AutorestCI commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Aug 28, 2019

Uh oh!

yungezz Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

estebanreyl Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

estebanreyl Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estebanreyl commented Aug 29, 2019

Uh oh!

Uh oh!

estebanreyl commented Aug 30, 2019

Uh oh!

estebanreyl commented Aug 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungezz commented Sep 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebanreyl commented Aug 28, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 28, 2019 •

edited

Loading

AutorestCI commented Aug 28, 2019 •

edited

Loading

AutorestCI commented Aug 28, 2019 •

edited

Loading

estebanreyl Aug 28, 2019 •

edited

Loading

estebanreyl Aug 28, 2019 •

edited

Loading

estebanreyl commented Aug 30, 2019 •

edited

Loading