Dev storagecache microsoft.storagecache 2019 06 01 preview#7043
Merged
lirenhe merged 55 commits intoAzure:masterfrom Aug 30, 2019
Merged
Conversation
…toragecache-2019-06-01-preview initial swagger for StorageCache RP
…toragecache-2019-06-01-preview review edits
…toragecache-2019-06-01-preview fix cosmetic stuff with tabs, added path for storagetarget that was f…
2. "Cluster" -> "Cache" globally 3. targettype enum fixed to have unknown type for future insurance 4. usage models examples fixed; they have short nonlocalized names now 5. x-ms-discriminator tag added to StorageTargets 6. modelasstring has been changed to true for enums 7. Avere expunged 8. vFXT expunged
…toragecache-2019-06-01-preview * fixed readOnly; it was erroneously on some Cache properties * "Cluster" -> "Cache" globally * targettype enum fixed to have unknown type for future insurance * usage models examples fixed; they have short nonlocalized names now * x-ms-discriminator tag added to StorageTargets * modelasstring has been changed to true for enums * Avere expunged * vFXT expunged * converted path property on StorageTarget from string to array of namespaceJunctions * removed some dead code and misc cosmetic cleanup
…toragecache-2019-06-01-preview fix typo in databox json
…toragecache-2019-06-01-preview added python generation file
…toragecache-2019-06-01-preview add swagger to sdk section
* add some provisioning states for cache * update a few doc strings * make usagemodel display an object instead of string
…toragecache-2019-06-01-preview * add provisioning state to storage targets
…toragecache-2019-06-01-preview capitalize states for consistency, add Unknown
change cache listing and skus
add 2019-08-01-preview API version
In Testing, Please Ignore[Logs] (Generated from b62ee6d, Iteration 6)
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
nschonni
reviewed
Aug 27, 2019
Contributor
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
You can add words that should pass the spellcheck to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt
...gecache/resource-manager/Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json
Outdated
Show resolved
Hide resolved
...gecache/resource-manager/Microsoft.StorageCache/preview/2019-06-01-preview/storagecache.json
Outdated
Show resolved
Hide resolved
Contributor
|
@lirenhe - as @romahamu mentioned - the review was already done by SDK and ARM team in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/675 |
nschonni
reviewed
Aug 27, 2019
Remove Node.js triggers for SDK generation
lirenhe
reviewed
Aug 29, 2019
lirenhe
approved these changes
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK and ARM team reviews are done in the private repository with PR https://github.com/Azure/azure-rest-api-specs-pr/pull/675
@waffe7 @mozehgir @sergey-shandar
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.