Support DataLakeStorage 10-31-19 version by DadanielZ · Pull Request #7032 · Azure/azure-rest-api-specs

DadanielZ · 2019-08-23T17:35:25Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-23T17:35:29Z

In Testing, Please Ignore

[Logs] (Generated from c350081, Iteration 5)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

AutorestCI · 2019-08-23T17:36:02Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-08-23T17:36:27Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2019-08-23T18:05:27Z

Can one of the admins verify this patch?

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

erich-wang

@DadanielZ , please follow step 6 in https://github.com/Azure/adx-documentation-pr/wiki/Review-Process:-Adding-new-API-version:
Please note that it is time-consuming to review the file line by line for every api-version. When you are creating the swagger specification for the new api-version, please copy the swagger specification from the previous version into the new api-versioned folder and commit it. After that overwrite it with the changes for the new api-version. This makes it easy for us to review the changes.

DadanielZ · 2019-08-26T18:19:24Z

@erich-wang updated.

erich-wang · 2019-08-26T18:42:31Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+  "info": {
+    "description": "Azure Data Lake Storage provides storage for Hadoop and other big data workloads.",
+    "title": "Azure Data Lake Storage REST API",
+    "version": "2018-11-09",


update version?

erich-wang · 2019-08-26T18:47:37Z

@yungezz , could you assign someone to take a look at Breaking change error in CI?

yungezz · 2019-08-27T02:08:10Z

hi @michaeljqzq could you pls help to look at the breaking change failure? thanks.

yungezz · 2019-08-27T03:08:54Z

Hi @erich-wang , after investigation @michaeljqzq identified error in breakingChange tool is a tool issue, he will fix it. Pls ping me to force merge the PR when reviewing done. Thanks!

DadanielZ · 2019-08-28T17:46:48Z

@erich-wang @yungezz could you help to merge it if the review is done?

erich-wang · 2019-08-29T06:25:47Z

@DadanielZ , we're waiting for review from azure api board, that's why I added label WaitingForAzureAPIBoard. I'll ping them if no response next week.

DadanielZ · 2019-09-03T04:28:32Z

Hi @erich-wang, could you help to ping azure api board to review? thanks!

erich-wang · 2019-09-03T08:43:50Z

Hi @erich-wang, could you help to ping azure api board to review? thanks!

Already sent email this morning.

DadanielZ · 2019-09-05T02:37:54Z

@erich-wang thanks, is there anyone reviewing this PR?

erich-wang · 2019-09-10T11:53:42Z

@erich-wang thanks, is there anyone reviewing this PR?

I've sent email to api review team and you were in the email thread.

johanste · 2019-09-16T17:56:07Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+      "x-ms-parameter-location": "client"
+    },
+    "dnsSuffix": {
+      "default": "dfs.core.windows.net",


Default values for required parameters are not allowed.

Hi @johanste, thanks for the review. but these are not part of this PR.
I was following step 6 in https://github.com/Azure/adx-documentation-pr/wiki/Review-Process:-Adding-new-API-version:
copy the swagger specification from the previous version into the new api-versioned folder and commit it. After that overwrite it with the changes for the new api-version.
So this makes it easy for you to review the changes.

All the changes for the new API is in 6d4ed71
and c350081,
Thanks.

johanste · 2019-09-16T17:57:38Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+          "type": "boolean"
+        },
+        "lastModified": {
+          "type": "string"


Isn't this a date-time? Or is the precision too high/more than milliseconds - and if so, is there really a need to use sub-millisecond granularity?

johanste · 2019-09-16T17:58:04Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+        }
+      }
+    },
+    "Path": {


Are none of the properties required?

johanste · 2019-09-16T17:58:39Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+        "group": {
+          "type": "string"
+        },
+        "permissions": {


The plural in the property name usually implies that the value is a collection (list etc.).

johanste · 2019-09-17T00:00:06Z

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json

+            "in": "header",
+            "required": false,
+            "type": "string"
+


While technically correct, this description is probably not the best for human consumption. I would recommend describing what the different positions mean.

If you want to provide a regex, you can do so using the pattern, minLength and maxLength properties.

johanste · 2019-09-17T00:02:24Z

Only one optional query parameter added. No need for full REST API review in front of board. Signed off.

erich-wang · 2019-09-17T06:57:23Z

/azp run public.rest-api-specs

azure-pipelines · 2019-09-17T06:57:33Z

Azure Pipelines successfully started running 1 pipeline(s).

DadanielZ · 2019-09-17T17:33:51Z

Thank you for your help! @johanste @erich-wang @NullMDR @yungezz

nschonni reviewed Aug 23, 2019

View reviewed changes

...fication/storage/data-plane/Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json Outdated Show resolved Hide resolved

yungezz assigned erich-wang Aug 26, 2019

erich-wang suggested changes Aug 26, 2019

View reviewed changes

DadanielZ added 2 commits August 26, 2019 18:07

Copy 2018-11-09 DataLakeStorage.json

1b081ff

Update DataLakeStorage.json for 2019-10-31 version

6d4ed71

DadanielZ force-pushed the DataLakeStorage10-31-19 branch from 299a476 to 6d4ed71 Compare August 26, 2019 18:17

erich-wang suggested changes Aug 26, 2019

View reviewed changes

erich-wang added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Aug 26, 2019

update version in DataLakeStorage.json

c350081

johanste reviewed Sep 16, 2019

View reviewed changes

johanste reviewed Sep 17, 2019

View reviewed changes

johanste added the AzureAPIBoardSignedOff label Sep 17, 2019

johanste removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Sep 17, 2019

erich-wang approved these changes Sep 17, 2019

View reviewed changes

PhoenixHe-NV closed this Sep 17, 2019

PhoenixHe-NV reopened this Sep 17, 2019

yungezz merged commit 0f75a7a into Azure:master Sep 17, 2019

Conversation

DadanielZ commented Aug 23, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from c350081, Iteration 5)

Uh oh!

AutorestCI commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Aug 23, 2019

Uh oh!

Uh oh!

erich-wang left a comment

Choose a reason for hiding this comment

Uh oh!

DadanielZ commented Aug 26, 2019

Uh oh!

erich-wang Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

DadanielZ Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

erich-wang commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungezz commented Aug 27, 2019

Uh oh!

yungezz commented Aug 27, 2019

Uh oh!

DadanielZ commented Aug 28, 2019

Uh oh!

erich-wang commented Aug 29, 2019

Uh oh!

DadanielZ commented Sep 3, 2019

Uh oh!

erich-wang commented Sep 3, 2019

Uh oh!

DadanielZ commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erich-wang commented Sep 10, 2019

Uh oh!

johanste Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

DadanielZ Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johanste Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

johanste Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

johanste Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

johanste Sep 17, 2019

Choose a reason for hiding this comment

Uh oh!

johanste commented Sep 17, 2019

Uh oh!

erich-wang commented Sep 17, 2019

Uh oh!

azure-pipelines bot commented Sep 17, 2019

Uh oh!

DadanielZ commented Sep 17, 2019

Uh oh!

openapi-sdkautomation bot commented Aug 23, 2019 •

edited

Loading

AutorestCI commented Aug 23, 2019 •

edited

Loading

AutorestCI commented Aug 23, 2019 •

edited

Loading

erich-wang commented Aug 26, 2019 •

edited

Loading

DadanielZ commented Sep 5, 2019 •

edited

Loading

DadanielZ Sep 16, 2019 •

edited

Loading