Skip to content

fix: storagesync model validation errors#6929

Merged
yungezz merged 1 commit intoAzure:masterfrom
nschonni:fix--storagesync-model-validation-errors
Aug 16, 2019
Merged

fix: storagesync model validation errors#6929
yungezz merged 1 commit intoAzure:masterfrom
nschonni:fix--storagesync-model-validation-errors

Conversation

@nschonni
Copy link
Contributor

  • Remove empty body
  • Remove empty "properties"

@AutorestCI
Copy link

AutorestCI commented Aug 11, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Aug 11, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lirenhe
Copy link
Member

lirenhe commented Aug 12, 2019

@nschonni , I saw a couple of validation error for this PR, could you take a look?

- Remove empty body
- Remove empty "properties"
@nschonni nschonni force-pushed the fix--storagesync-model-validation-errors branch from 417b317 to 78dcf5c Compare August 12, 2019 05:19
@nschonni
Copy link
Contributor Author

@lirenhe I removed the spec changes so the model validation should be happy. When the spec doesn't get touched, the CI doesn't run the model validation, but the errors are still there

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019

In Testing, Please Ignore

[Logs] (Generated from 78dcf5c, Iteration 1)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning storagesync/mgmt/2018-04-02 [Logs]
  • Warning storagesync/mgmt/2018-07-01 [Logs]
  • Warning storagesync/mgmt/2018-10-01 [Logs]
  • Warning storagesync/mgmt/2019-02-01 [Logs]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@lirenhe
Copy link
Member

lirenhe commented Aug 13, 2019

@ankushbindlish2, please take a look at this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants