Skip to content

Update vmssNetworkInterface.json #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RajarajeshwariHS wants to merge 1 commit into from
Closed

Update vmssNetworkInterface.json #6916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on/network/resource-manager/Microsoft.Network/stable/2019-06-01/vmssNetworkInterface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"info": {
"title": "NetworkManagementClient",
"description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
"version": "2017-03-30"
Copy link
Member

@tjprescott tjprescott Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change?

Copy link
Contributor

@anton-evseev anton-evseev Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @RajarajeshwariHS

Copy link
Author

@RajarajeshwariHS RajarajeshwariHS Aug 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by @number213 as it was required for this PR : #6692

Copy link
Contributor

@anton-evseev anton-evseev Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if we're updating API version in vmssPublicIpAddress, we should also update it in vmssNetworkInterface. I guess the question is what's the reason for changing API version in VMSS specs? Just to use the latest one?

Copy link
Author

@RajarajeshwariHS RajarajeshwariHS Aug 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use latest Microsoft.Azure.Management.Network nuget which is of version “19.12.0-preview”. I searched in the source repository of this repo and found out the required API : ListVirtualMachineScaleSetPublicIPAddressesWithHttpMessagesAsync
https://github.com/Azure/azure-sdk-for-net/blob/dc23a39caf37d07f02512540d20c29866ff83759/sdk/network/Microsoft.Azure.Management.Network/src/Generated/PublicIpAddressesOperations.cs

Here the apiVersion is set as “2017-03-30”. We require it to be “2018-10-01”.
So, here #6692 I have made the required changes to vmssPublicIPAddress and as we have to also update vmssNetworkInterface, I have made the changes here.

Copy link
Contributor

@anton-evseev anton-evseev Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RajarajeshwariHS makes sense.
If you need updated Network SDK asap, we can work on getting you a signed nupkg, because the next NuGet release will be in a month

"version": "2018-10-01"
},
"host": "management.azure.com",
"schemes": [
Expand Down