Skip to content

Add missing read-only property "outboundRules" in LoadBalancer specs#6908

Merged
yungezz merged 1 commit intoAzure:masterfrom
anton-evseev:outbound-rules
Aug 29, 2019
Merged

Add missing read-only property "outboundRules" in LoadBalancer specs#6908
yungezz merged 1 commit intoAzure:masterfrom
anton-evseev:outbound-rules

Conversation

@anton-evseev
Copy link
Contributor

Copied changes for outbound rules from #6493 to older API versions:

  • Added read-only property "outboundRules" to backendAddressPool
  • Added example for creating LB with outbound rules
  • Updated other load balancer examples to reflect the fact that outbound rules are available only with Standard SKU

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpg1go0d1j/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpg1go0d1j/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[30300:0x2fd6cc0]    67214 ms: Mark-sweep 1378.4 (1425.6) -> 1378.3 (1426.1) MB, 1429.9 / 0.0 ms  (average mu = 0.160, current mu = 0.122) allocation failure GC in old space requested
[30300:0x2fd6cc0]    68624 ms: Mark-sweep 1378.9 (1426.1) -> 1378.9 (1426.6) MB, 1407.4 / 0.0 ms  (average mu = 0.084, current mu = 0.002) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xcc2b64dbe1d]
Security context: 0x151d7a19e6e9 <JSObject>
    1: storeMappingPair(aka storeMappingPair) [0x18597736229] [/node_modules/yaml-ast-parser/dist/src/loader.js:~270] [pc=0xcc2b6d6a6ba](this=0x0230c35026f1 <undefined>,state=0x108698451699 <State map = 0x11e28937ef89>,_result=0x1538965a6cf9 <Object map = 0xc8936ae8d79>,keyTag=0x0230c35022b1 <null>,keyNode=0x0a7177bfff29 <Object map = 0xc8936ae96c1>,valueNode...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xcc2b64dbe1d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5632

@anton-evseev
Copy link
Contributor Author

Java SDK job failed due to 2hr timeout. I guess I've updated too many API versions at once. If this is a problem, @sergey-shandar, I could split this PR in two by year (2018/2019).

@anton-evseev
Copy link
Contributor Author

@sergey-shandar gentle ping

@anton-evseev
Copy link
Contributor Author

@zikalino @lirenhe could you please take a look at this PR?

"$ref": "./network.json#/definitions/SubResource",
"description": "Gets outbound rules that use this backend address pool."
},
"outboundRules": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update a stable version is breaking change, pls make the change in new service tag.

@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

Hi @number213 this PR adding new property to a stable version. it's breaking change. add @MikhailTryakhov for awareness.

@anton-evseev
Copy link
Contributor Author

@yungezz I don't really see how it's a breaking change. It's a bugfix to add missing read-only property, it won't break anything on customer's side. We've already added it to 2019-06-01, this PR is to add this property to older API versions since some SDKs are multi-API

@yungezz
Copy link
Member

yungezz commented Aug 29, 2019

@yungezz I don't really see how it's a breaking change. It's a bugfix to add missing read-only property, it won't break anything on customer's side. We've already added it to 2019-06-01, this PR is to add this property to older API versions since some SDKs are multi-API

it's ok if this is a swagger file bug fixing.

@yungezz yungezz closed this Aug 29, 2019
@yungezz yungezz reopened this Aug 29, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 29, 2019

In Testing, Please Ignore

[Logs] (Generated from 658cfc1, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@yungezz
Copy link
Member

yungezz commented Aug 29, 2019

reopen to trigger ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants