Skip to content

Create swagger definitions for new Microsoft.OperationalInsights reso… #6883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yungezz merged 20 commits into from
Sep 5, 2019
Merged

Create swagger definitions for new Microsoft.OperationalInsights reso… #6883

yungezz merged 20 commits into from
Sep 5, 2019

Conversation

@olterner
Copy link
Contributor

@olterner olterner commented Aug 6, 2019 •
edited
Loading

…urce - Cluster

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 6, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 7d6142a, Iteration 15)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning operationalinsights/mgmt/2015-03-20 [Logs]
  • Warning preview/operationalinsights/mgmt/2015-11-01-preview [Logs]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Aug 6, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 6, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7069

@azuresdkci azuresdkci requested a review from sarangan12 August 6, 2019 20:18
@AutorestCI
Copy link

AutorestCI commented Aug 6, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 6, 2019

Can one of the admins verify this patch?

ryansbenson
ryansbenson reviewed Aug 12, 2019
View reviewed changes
...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json Outdated
},
"description": "The list clusters operation response."
},
"Object": {
Copy link
Contributor

@ryansbenson ryansbenson Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Contributor Author

@olterner olterner Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Contributor Author

@olterner olterner Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json Outdated
"description": "The resource definition.",
"x-ms-azure-resource": true
},
"ProxyResource": {
Copy link
Contributor

@ryansbenson ryansbenson Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required

Copy link
Contributor Author

@olterner olterner Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@ryansbenson ryansbenson added ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019
@sarangan12 sarangan12 removed their request for review August 14, 2019 13:26
@sarangan12 sarangan12 removed their assignment Aug 14, 2019
ryansbenson
ryansbenson reviewed Aug 14, 2019
View reviewed changes
ryansbenson
ryansbenson reviewed Aug 15, 2019
View reviewed changes
...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json Outdated
},
"description": "Resource tags"
},
"location": {
Copy link
Contributor

@ryansbenson ryansbenson Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location typically isn't changeable after create. Do you support this?

Copy link
Contributor Author

@olterner olterner Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I wanted to remove it then though it can be useful for migrations...
But on the other side i don't really know when we are going to support it so i'm removing for now

@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
yoramsinger
yoramsinger reviewed Aug 18, 2019
View reviewed changes
...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json Outdated
}
},
"operationId": "Clusters_ListByResourceGroup",
"description": "Gets clusters in a resource group.",
Copy link
Contributor

@yoramsinger yoramsinger Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Log Analytics" before each "cluster/s" in the descriptions. Also use "the Log Analytics clusters"

@AutorestCI AutorestCI mentioned this pull request Aug 18, 2019
Merged
@yungezz
Copy link
Member

yungezz commented Sep 2, 2019

Hi @olterner any update on this PR?

@olterner
Copy link
Contributor Author

olterner commented Sep 2, 2019

We're waiting for final approval from Azure Resource Manager RP API Review team

KrisBash
KrisBash approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ARM feedback appears to be addressed. Signing off for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 4, 2019
@yungezz yungezz merged commit 454b15b into Azure:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

+3 more reviewers

@nschonni nschonni nschonni left review comments

@yoramsinger yoramsinger yoramsinger left review comments

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.