Skip to content

Conversation

@pabowers
Copy link
Contributor

@pabowers pabowers commented Aug 2, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2019

In Testing, Please Ignore

[Logs] (Generated from 84546e9, Iteration 5)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning hanaonazure/resource-manager/v2017_11_03_preview [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-hanaonazure [Logs]

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6636

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5419

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@pabowers pabowers force-pushed the pabowers/additional-get-properties branch 2 times, most recently from 4fe60cd to f1354d9 Compare August 2, 2019 22:51
@pabowers pabowers force-pushed the pabowers/additional-get-properties branch from f1354d9 to 84546e9 Compare August 6, 2019 16:52
@jhendrixMSFT
Copy link
Member

@pabowers is this live?

@pabowers
Copy link
Contributor Author

pabowers commented Aug 6, 2019

I am going to push it to our repo after this one goes in

@jhendrixMSFT jhendrixMSFT merged commit 5fb3c80 into master Aug 6, 2019
@JackTn JackTn deleted the pabowers/additional-get-properties branch August 9, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants