fixing subscription id issue #6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Automation [Logs] (Generated from 10bf6ed, Iteration 3)
|
Automation for azure-sdk-for-pythonA PR has been created for you: |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goA PR has been created for you: |
added 2 commits
July 31, 2019 11:06
| "required": true, | ||
| "type": "string", | ||
| "description": "The ID of the target subscription.", | ||
| "minLength": 1 |
Contributor
There was a problem hiding this comment.
Why do we require 'minLength' property?
Author
There was a problem hiding this comment.
Just following common file here:
It just indicates that it shouldn't be empty string.
mahakjain314
approved these changes
Jul 31, 2019
yungezz
reviewed
Jul 31, 2019
| "type": "string", | ||
| "description": "The Azure subscription id." | ||
| "description": "The ID of the target subscription.", | ||
| "minLength": 1 |
Member
There was a problem hiding this comment.
since this changed stable version, does it require a new version?
yungezz
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix autogeneration problem when subscription_id is duplicated and appears as subscription_id1 for the second time.