Skip to content

Conversation

@ruowan
Copy link
Member

@ruowan ruowan commented Jul 31, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019

SDK Automation [Logs] (Generated from 442ada4, Iteration 1)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@ruowan
Copy link
Member Author

ruowan commented Jul 31, 2019

@michaeljqzq @NullMDR pls have a look.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV PhoenixHe-NV self-assigned this Jul 31, 2019
@michaeljqzq michaeljqzq merged commit 7f176d2 into Azure:master Jul 31, 2019
inputs:
verbose: false
- script: 'npm install -D @azure/[email protected].0'
- script: 'npm install -D @azure/[email protected].1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you switch it to drop the patch version, it will keep using the latest patch (till you just update the package.json version and drop this build)

Suggested change
- script: 'npm install -D @azure/[email protected].1'
- script: 'npm install -D @azure/[email protected]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit version is better than implicit version here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants