Skip to content

Add way to override the service url example#6793

Merged
Juliehzl merged 3 commits intoAzure:masterfrom
solankisamir:addexampleapimport
Aug 4, 2019
Merged

Add way to override the service url example#6793
Juliehzl merged 3 commits intoAzure:masterfrom
solankisamir:addexampleapimport

Conversation

@solankisamir
Copy link
Member

@solankisamir solankisamir commented Jul 30, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.


Added example on how to override the ServiceUrl when doing the API Import

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 82ca10e, Iteration 8)

Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning apimanagement/mgmt/2016-07-07 [Logs]
  • Warning apimanagement/mgmt/2016-10-10 [Logs]
  • Warning apimanagement/mgmt/2017-03-01 [Logs]
  • Warning apimanagement/mgmt/2018-01-01 [Logs]
  • Warning apimanagement/mgmt/2019-01-01 [Logs]
  • Warning preview/apimanagement/mgmt/2018-06-01-preview [Logs]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 30, 2019
Merged
@azuresdkci azuresdkci requested a review from Juliehzl July 30, 2019 22:00
@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 30, 2019

Can one of the admins verify this patch?

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 31, 2019
@solankisamir
Copy link
Member Author

solankisamir commented Aug 2, 2019

@Juliehzl I am only adding an example. I am not changing any contract

@Juliehzl
Copy link
Contributor

Juliehzl commented Aug 4, 2019

@solankisamir Well, thanks for the reminder.

@Juliehzl Juliehzl removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 4, 2019
@Juliehzl Juliehzl merged commit 37fcc6d into Azure:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

+1 more reviewer

@nschonni nschonni nschonni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Juliehzl Juliehzl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@solankisamir @AutorestCI @azuresdkci @Juliehzl @nschonni