fix: automation model validation errors#6782
Merged
raych1 merged 1 commit intoAzure:masterfrom Aug 2, 2019
Merged
Conversation
Contributor
nschonni
commented
Jul 30, 2019
nschonni
commented
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- "path" -> "folderPath"
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors - "path" -> "folderPath"
SDK Automation [Logs] (Generated from 7c45716, Iteration 1)
|
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
@raych1 here are the outstanding errors (I only fixed those ones mentioned in the commit message), just FYI, here are the still failing rules: This one seems like a bug, because a Delete probably shouldn't be returning anything Some missing response bodies in the examples |
Member
|
Thanks @nschonni , there're a few invalid_type errors. Do you know how cause this? |
Contributor
Author
|
I think Swagger 2 or the current x-ms-example stuff doesn't have a good way to represent file responses in an example. |
Member
|
@nschonni , can we use this PR and add more commits to fix other errors? |
Contributor
Author
|
Sure if you want. The "allow edits from maintainers" checkbox is on |
Member
|
Sorry, what I meant is will you continue to fix other errors along with this PR? |
Contributor
Author
|
Ah, no I don't think I can fix any of those other ones. EX: removing the response schema from the deletes would probably be a breaking change, and it could be correct. Also adding the response I'd need to know what they'd look like. |
Member
|
I see, comes back to this PR. What's the reason changing |
Contributor
Author
|
The property is "folderPath" in the spec rather than "path" Could be a spec error, and I can undo it if you want |
raych1
approved these changes
Aug 2, 2019
Member
raych1
left a comment
raych1
left a comment
There was a problem hiding this comment.
Looks good to me for the fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.