Skip to content

fix: network model validation errors #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tjprescott merged 1 commit into from
Jul 31, 2019
Merged

fix: network model validation errors #6750

tjprescott merged 1 commit into from
Jul 31, 2019

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 28, 2019 •
edited
Loading

  • Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
  • Remove responses for 202s with no schema defined for RESPONSE_SCHEMA_NOT_IN_SPEC errors
  • The OBJECT_ADDITIONAL_PROPERTIES are not addressed
  • "Thumbprint" -> "thumbprint"

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 1741558, Iteration 3)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Failed network/mgmt/2015-06-15 [Logs]
  • In-Progress network/mgmt/2016-03-30 [Logs]
  • In-Progress network/mgmt/2016-06-01 [Logs]
  • In-Progress network/mgmt/2016-09-01 [Logs]
  • In-Progress network/mgmt/2016-12-01 [Logs]
  • In-Progress network/mgmt/2017-03-01 [Logs]
  • In-Progress network/mgmt/2017-06-01 [Logs]
  • In-Progress network/mgmt/2017-08-01 [Logs]
  • In-Progress network/mgmt/2017-09-01 [Logs]
  • In-Progress network/mgmt/2017-10-01 [Logs]
  • In-Progress network/mgmt/2017-11-01 [Logs]
  • In-Progress network/mgmt/2018-01-01 [Logs]
  • In-Progress network/mgmt/2018-02-01 [Logs]
  • In-Progress network/mgmt/2018-04-01 [Logs]
  • In-Progress network/mgmt/2018-06-01 [Logs]
  • In-Progress network/mgmt/2018-07-01 [Logs]
  • In-Progress network/mgmt/2018-08-01 [Logs]
  • In-Progress network/mgmt/2018-10-01 [Logs]
  • In-Progress network/mgmt/2018-11-01 [Logs]
  • In-Progress network/mgmt/2018-12-01 [Logs]
  • In-Progress network/mgmt/2019-02-01 [Logs]
  • In-Progress network/mgmt/2019-04-01 [Logs]
  • In-Progress network/mgmt/2019-06-01 [Logs]
  • In-Progress preview/network/mgmt/2015-05-01-preview [Logs]
Warning JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-network [Logs]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 28, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 28, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@azuresdkci azuresdkci requested a review from tjprescott July 28, 2019 18:40
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 28, 2019
Merged
@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 28, 2019

Can one of the admins verify this patch?

@nschonni
Copy link
Contributor Author

nschonni commented Jul 28, 2019

@number213 @MikhailTryakhov I PR'd this to master since it's mostly related to older specs. I can try and rebase to the network release branch if you want

@anton-evseev
Copy link
Contributor

anton-evseev commented Jul 29, 2019

@nschonni @MikhailTryakhov I think the latest API version should be fixed in release branch but the older ones – in master. That way release PR into master would have less changes that could stall it. Also, in release branch we run our validation scritps only for the latest API version.

@MikhailTryakhov
Copy link
Contributor

MikhailTryakhov commented Jul 29, 2019

@sergey-shandar agree with Anton (previous comment) related to the changes in older APIs... Please confirm and review PR

@nschonni
Copy link
Contributor Author

nschonni commented Jul 29, 2019

OK, so I should move the one change to 2019-06-01 or also the 2019-04-01 changes too?

@anton-evseev
Copy link
Contributor

anton-evseev commented Jul 30, 2019

@nschonni in this case, 2019-04-01 and earlier should be merged into master, changes for 2019-06-01 should go to network-july-release

@nschonni
fix: network model validation errors
1741558 
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- Remove responses for 202s with no schema defined for RESPONSE_SCHEMA_NOT_IN_SPEC errrors
- The OBJECT_ADDITIONAL_PROPERTIES are not addressed
- "Thumbprint" -> "thumbprint"
@nschonni nschonni force-pushed the fix--network-model-validation-errors branch from 23948dd to 1741558 Compare July 30, 2019 15:52
@nschonni
Copy link
Contributor Author

nschonni commented Jul 30, 2019 •
edited
Loading

OK, pulled out the 2019-06-01 change and created #6790

@tjprescott tjprescott merged commit d8e61ec into Azure:master Jul 31, 2019
@nschonni nschonni deleted the fix--network-model-validation-errors branch July 31, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@tjprescott tjprescott Awaiting requested review from tjprescott

1 more reviewer

@anton-evseev anton-evseev anton-evseev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tjprescott tjprescott

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nschonni @AutorestCI @azuresdkci @anton-evseev @MikhailTryakhov @tjprescott