Skip to content

Description review edits For Redis Cache swaggers#673

Merged
amarzavery merged 3 commits intoAzure:masterfrom
steved0x:sd112
Nov 10, 2016
Merged

Description review edits For Redis Cache swaggers#673
amarzavery merged 3 commits intoAzure:masterfrom
steved0x:sd112

Conversation

@steved0x
Copy link
Copy Markdown
Member

@steved0x steved0x commented Nov 4, 2016

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

This change is Reviewable

@azurecla
Copy link
Copy Markdown

azurecla commented Nov 4, 2016

Hi @steved0x, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (sdanie). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@steved0x
Copy link
Copy Markdown
Member Author

steved0x commented Nov 7, 2016

Most of the checklist above doesn't apply to me since I did not author the swagger - I just edited the descriptions on a previously approved and merged swagger.

@steved0x
Copy link
Copy Markdown
Member Author

steved0x commented Nov 9, 2016

#sign-off

"info": {
"title": "RedisManagementClient",
"description": ".Net client wrapper for the REST API for Azure Redis Cache Management Service",
"description": ".Net client wrapper for the REST API for Azure Redis Cache Management Service.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steved0x - Dont you think the description should not have keywords like .NET and client in it? The spec is a representation of the API and would be used to generate clients in different languages. Plus it wouldnt look good to have the word client specified in the ref docs.

@steved0x
Copy link
Copy Markdown
Member Author

@amarzavery I made the requested changes, thank you.

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

No modification for Python

@AutorestCI
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants