Skip to content

Conversation

@mabhard
Copy link
Contributor

@mabhard mabhard commented Jul 23, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2019

SDK Automation [Logs] (Generated from 56ccb11, Iteration 7)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/compute/azure-mgmt-compute [Logs]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • Failed compute/resource-manager/v2017_03_30 [Logs]
  • Failed compute/resource-manager/v2017_09_01 [Logs]
  • Failed compute/resource-manager/v2017_12_01 [Logs]
  • Failed compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Failed @azure/arm-compute [Logs]
Failed Go: Azure/azure-sdk-for-go [Logs] [Diff]
  • Failed compute/mgmt/2015-06-15 [Logs]
  • Failed compute/mgmt/2016-03-30 [Logs]
  • Failed compute/mgmt/2017-03-30 [Logs]
  • Failed compute/mgmt/2017-09-01 [Logs]
  • Failed compute/mgmt/2017-12-01 [Logs]
  • Failed compute/mgmt/2018-04-01 [Logs]
  • Failed compute/mgmt/2018-06-01 [Logs]
  • Failed compute/mgmt/2018-10-01 [Logs]
  • Failed compute/mgmt/2019-03-01 [Logs]
  • Failed compute/mgmt/2019-07-01 [Logs]
  • Failed containerservice/mgmt/2016-03-30 [Logs]
  • Failed containerservice/mgmt/2016-09-30 [Logs]
  • Failed containerservice/mgmt/2017-01-31 [Logs]
  • Failed preview/compute/mgmt/2016-04-30-preview [Logs]
  • Failed preview/containerservice/mgmt/2015-11-01-preview [Logs]
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6461

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5332

"type": "string"
},
"description": "Availability Zone to use for this host group – only single zone is supported. The zone can be assigned only during creation. If not provided, the group supports all zones in the region. If provided, enforces each host in the group to be in the same zone."
"description": "Availability Zone to use for this host group only single zone is supported. The zone can be assigned only during creation. If not provided, the group supports all zones in the region. If provided, enforces each host in the group to be in the same zone."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a period after "Availability Zone to use for this host group" and make "Only single zone is supported" as a separate statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"type": "string"
},
"description": "Availability Zone to use for this host group – only single zone is supported. The zone can be assigned only during creation. If not provided, the group supports all zones in the region. If provided, enforces each host in the group to be in the same zone."
"description": "Availability Zone to use for this host group only single zone is supported. The zone can be assigned only during creation. If not provided, the group supports all zones in the region. If provided, enforces each host in the group to be in the same zone."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@celikcigdem
Copy link
Contributor

Looks good to me. Signing off as the CRP SME for dedicated hosts.

@zikalino zikalino merged commit 20c172b into Azure:master Jul 24, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
* Update enum and size type properties for firmware resources for Microsoft.IoTFirmwareDefense

* Trying to trigger rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants