[Do not merge]Add azure managed application, get application definition API by dandanwang0320 · Pull Request #6680 · Azure/azure-rest-api-specs

dandanwang0320 · 2019-07-19T17:03:57Z

Reference code
ARM\AzureUX\ARM\src\providers\Roles\Providers.Feature\Controllers\ApplicationDefinitionArtifactController.cs

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-19T17:04:00Z

In Testing, Please Ignore

[Logs] (Generated from 5e7f34b, Iteration 6)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs]

No packages generated.

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

features/resource-manager/v2015_12_01 [Logs] [Generation PR]
locks/resource-manager/v2016_09_01 [Logs]
policy/resource-manager/v2016_12_01 [Logs]
policy/resource-manager/v2018_03_01 [Logs]
policy/resource-manager/v2018_05_01 [Logs]
policy/resource-manager/v2019_01_01 [Logs]
resources/resource-manager/v2016_06_01 [Logs]
resources/resource-manager/v2016_09_01 [Logs]
resources/resource-manager/v2018_02_01 [Logs]
resources/resource-manager/v2018_06_01 [Logs]
resources/resource-manager/v2019_03_01 [Logs]
resources/resource-manager/v2019_05_01 [Logs]
resources/resource-manager/v2019_05_10 [Logs]
resources/resource-manager/v2019_07_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/resources/mgmt/2015-10-01-preview [Logs]
preview/resources/mgmt/2016-09-01-preview [Logs]
preview/resources/mgmt/2017-06-01-preview [Logs]
resources/mgmt/2015-01-01 [Logs]
resources/mgmt/2015-11-01 [Logs]
resources/mgmt/2015-12-01 [Logs]
resources/mgmt/2016-02-01 [Logs]
resources/mgmt/2016-04-01 [Logs]
resources/mgmt/2016-06-01 [Logs]
resources/mgmt/2016-07-01 [Logs]
resources/mgmt/2016-09-01 [Logs]
resources/mgmt/2016-12-01 [Logs]
resources/mgmt/2017-05-10 [Logs]
resources/mgmt/2017-09-01 [Logs]
resources/mgmt/2018-02-01 [Logs]
resources/mgmt/2018-03-01 [Logs]
resources/mgmt/2018-05-01 [Logs]
resources/mgmt/2018-06-01 [Logs]
resources/mgmt/2019-01-01 [Logs]
resources/mgmt/2019-03-01 [Logs] [Instructions] [Generation PR]
- resources.mgmt.2019-03-01.zip
resources/mgmt/2019-05-01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-managedapplications [Logs] [Instructions] [Generation PR]
- azure-arm-managedapplications-1.0.2.tgz
@azure/arm-resources [Logs] [Instructions] [Generation PR]
- azure-arm-resources-1.1.0.tgz

AutorestCI · 2019-07-19T17:06:10Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 65cfeddeff682bc643a103d6f35fae67802318d9
  stderr: 'fatal: reference is not a tree: 65cfeddeff682bc643a103d6f35fae67802318d9'

azuresdkci · 2019-07-19T17:07:53Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-19T17:08:30Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 65cfeddeff682bc643a103d6f35fae67802318d9
  stderr: 'fatal: reference is not a tree: 65cfeddeff682bc643a103d6f35fae67802318d9'

AutorestCI · 2019-07-19T17:15:29Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-03-01/managedapplications.json

raych1

@dandanwang0320 , pls resolve the CI failures.

…table/2019-03-01/managedapplications.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

dandanwang0320 · 2019-08-01T20:36:21Z

@dandanwang0320 , pls resolve the CI failures.

I think these errors are unrelated to this change. The new changes are in commit 75cf949

Also I have another PR 5889 that works on the same folder that should fix the model validations.
So I did not make the same fixes here.

raych1 · 2019-08-02T00:19:52Z

@dandanwang0320 , pls resolve the CI failures.

I think these errors are unrelated to this change. The new changes are in commit 75cf949
Also I have another PR 5889 that works on the same folder that should fix the model validations.
So I did not make the same fixes here.

@dandanwang0320 , it doens't allow duplicated operation_id - ApplicationDefinitions_Get defined. operation_id has to be unique.

…/azure-rest-api-specs into AddAppDefArtifact

raych1 · 2019-08-02T03:01:22Z

@dandanwang0320 , can you reference the errors to fix README.md file to include the referenced files.

dandanwang0320 · 2019-08-06T22:12:21Z

Should be fixed now. Also fixed model validation errors in example files.

@dandanwang0320 , can you reference the errors to fix README.md file to include the referenced files.

raych1 · 2019-08-07T01:24:03Z

@Tiano2017 @rajshah11 @vivsriaus, can you review this PR?

ravbhatnagar

@dandanwang0320 - please take a look

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-03-01/managedapplications.json

raych1 · 2019-08-13T01:15:42Z

@dandanwang0320 , please resolve the comments.

dandanwang0320 · 2019-08-27T00:49:50Z

Having a internal discussion about whether we should have this API.

ravbhatnagar · 2019-09-24T06:10:28Z

@dandanwang0320 - can you please confirm with Manohar whether this API needs to be documented. If not, please close the PR.

dandanwang0320 added 2 commits July 19, 2019 09:48

Initial commit to add original files to new version.

78fb8bb

Add app def artifact api.

75cf949

dandanwang0320 requested a review from stankovski as a code owner July 19, 2019 17:03

azuresdkci assigned raych1 Jul 19, 2019

azuresdkci requested a review from raych1 July 19, 2019 17:05

nschonni reviewed Jul 19, 2019

View reviewed changes

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-03-01/managedapplications.json Outdated Show resolved Hide resolved

raych1 requested changes Jul 21, 2019

View reviewed changes

Update specification/resources/resource-manager/Microsoft.Solutions/s…

1bd1f4e

…table/2019-03-01/managedapplications.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

AutorestCI mentioned this pull request Aug 1, 2019

[AutoPR resources/resource-manager] Add azure managed application, get application definition API Azure/azure-sdk-for-python#6613

Closed

dandanwang0320 added 2 commits August 1, 2019 17:47

Fix operation Id.

e26d1df

Merge branch 'AddAppDefArtifact' of https://github.com/dandanwang0320…

89753b6

…/azure-rest-api-specs into AddAppDefArtifact

Fix model validation.

5e7f34b

AutorestCI mentioned this pull request Aug 6, 2019

[AutoPR resources/resource-manager] Add azure managed application, get application definition API Azure/azure-sdk-for-go#5447

Closed

raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2019

ravbhatnagar reviewed Aug 8, 2019

View reviewed changes

...on/resources/resource-manager/Microsoft.Solutions/stable/2019-03-01/managedapplications.json Show resolved Hide resolved

ravbhatnagar added the ARMChangesRequested label Aug 8, 2019

dandanwang0320 changed the title ~~Add azure managed application, get application definition API~~ [Do not merge]Add azure managed application, get application definition API Aug 27, 2019

openapi-sdkautomation bot mentioned this pull request Aug 27, 2019

[AutoPR features/resource-manager/v2015_12_01] [Do not merge]Add azure managed application, get application definition API test-repo-billy/azure-sdk-for-java#254

Closed

dandanwang0320 closed this Sep 24, 2019

Conversation

dandanwang0320 commented Jul 19, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 5e7f34b, Iteration 6)

Uh oh!

AutorestCI commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Jul 19, 2019

Uh oh!

AutorestCI commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

raych1 left a comment

Choose a reason for hiding this comment

Uh oh!

dandanwang0320 commented Aug 1, 2019

Uh oh!

raych1 commented Aug 2, 2019

Uh oh!

raych1 commented Aug 2, 2019

Uh oh!

dandanwang0320 commented Aug 6, 2019

Uh oh!

raych1 commented Aug 7, 2019

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

raych1 commented Aug 13, 2019

Uh oh!

dandanwang0320 commented Aug 27, 2019

Uh oh!

ravbhatnagar commented Sep 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Jul 19, 2019 •

edited

Loading

AutorestCI commented Jul 19, 2019 •

edited

Loading

AutorestCI commented Jul 19, 2019 •

edited

Loading

AutorestCI commented Jul 19, 2019 •

edited

Loading