SecurityInsights: Investigation swagger updates

[dosegal]

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5722

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5428

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[azuresdkci]

Can one of the admins verify this patch?

[nschonni]

You can add the extra words to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt if they're correct

[openapi-sdkautomation]

In Testing, Please Ignore

[Logs] (Generated from be784b1, Iteration 9)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

• preview/securityinsight/mgmt/2017-08-01-preview [Logs] [Instructions] [Generation PR]
  • preview.securityinsight.mgmt.2017-08-01-preview.zip

Python: Azure/azure-sdk-for-python [Logs] [Diff]

• No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

• No packages generated.

[dosegal]

@shahabhijeet please review, thanks

[dosegal]

@shahabhijeet is there any update?

[majastrz]

Looks good from ARM side.

[dosegal]

@shahabhijeet @praries880 can someone please review the PR? thanks

[mmyyrroonn]

LGTM. I just want to confirm. Lot's of parameters set readOnly field to true. Usually, readOnly: true means these parameters should not appear in the PUT/PATCH methods. These parameters are set by design. Right?

[mmyyrroonn]

This field is a little bit tricky. What's kind of additionalData we want?

[dosegal]

additionalData can hold any custom field that should be part of the "entity" object. The fields don't share the same type, so this is why the type of "additionalProperties" is object.

[shahabhijeet]

@myronfanqiu go ahead merge the PR if you are satisfied with responses to your comments.

[dosegal]

LGTM. I just want to confirm. Lot's of parameters set readOnly field to true. Usually, readOnly: true means these parameters should not appear in the PUT/PATCH methods. These parameters are set by design. Right?

@myronfanqiu One of our resource types, called entities, supports only Get/Post operations in the server-side, and creation/modification is not allowed as part of the API. We have 15 different kinds of this resource, and they all share the same behavior. This is why you see many readOnly properties set to true.

[mmyyrroonn]

@dosegal Thanks!