Skip to content

Adding specification for 2019-07-01-preview version for Peering.#6630

Merged
Juliehzl merged 6 commits intoAzure:masterfrom
swetha-anantharajaiah:master
Jul 19, 2019
Merged

Adding specification for 2019-07-01-preview version for Peering.#6630
Juliehzl merged 6 commits intoAzure:masterfrom
swetha-anantharajaiah:master

Conversation

@swetha-anantharajaiah
Copy link
Copy Markdown
Contributor

@swetha-anantharajaiah swetha-anantharajaiah commented Jul 16, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 16, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from Juliehzl July 16, 2019 01:05
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
@Juliehzl
Copy link
Copy Markdown
Contributor

Juliehzl commented Jul 16, 2019

@swetha-anantharajaiah Please have a look at errors in CI checks and try to make all CI check pass.

KrisBash
KrisBash approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Comment thread ...ification/peering/resource-manager/Microsoft.Peering/preview/2019-07-01-preview/peering.json
@@ -0,0 +1,2389 @@
{
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, please copy the last version as is into the first commit, so that commits can be used to diff the changes.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@Juliehzl
Copy link
Copy Markdown
Contributor

Juliehzl commented Jul 17, 2019

@swetha-anantharajaiah Please have a look at CI check details. There may be two things to do: 1. Add input file for 2019-07-01 in readme.md; 2. location is required in your examples file.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jul 17, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 16550d7, Iteration 2)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • No packages generated.
Failed Go: Azure/azure-sdk-for-go [Logs] [Diff]
  • Failed preview/peering/mgmt/2019-03-01-preview [Logs]
Warning .NET: Azure/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Failed @azure/arm-peering [Logs]
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jul 17, 2019
Closed
@Juliehzl Juliehzl merged commit 4dbb4b0 into Azure:master Jul 19, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@ms-yuweizhao
Test Base Swagger API 2022-04-01-preview (based on 2022-03-01-preview) (
9e6ddfa 
Azure#6630)

* base: 2022-03-01-preview

* add swagger definition changes

* fix CI

* fix CI

* ref json

* ref json

* ref json

* ref json

* update swagger

* update swagger

* update swagger

* update swagger

* fix CI

* x-ms-pageable

* x-ms-pageable

* x-ms-pageable

* x-ms-pageable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Juliehzl Juliehzl

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swetha-anantharajaiah @azuresdkci @AutorestCI @Juliehzl @KrisBash